-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2756 - Account Selecotor Updates #2995
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Query List + Query Cache w/ max query limitor + Require active select on Typeahead + Loading indicator when query running + Delayed querying on input * Condensed code * Removed unused code
…nto 0_UpdatedAccountSelector
* Fetch array of objects instead of single * Results object creation changes
…nto 0_UpdatedAccountSelector
* Changes to error handling * AccountImage default sizes
* Error handling
This PR does not update account fetching on any other component, only Account Selector. |
* Changed remaining ChainStore(getAccount) call * Renamed functions and array to better namings
Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
sschiessl-bcp
requested changes
Aug 1, 2019
* Changes to states * Code simplifications
@sschiessl-bcp removed some unnecessary state changes and added a re-fetch delay. I've tested the update frequency after this, and it seems to be much better. |
Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
- fix uncaught promise in trxhelper Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2756 (overrides previous PR)
This PR contains a significant larger change to the structure, most notable is the usage of
fetchChainObjects
, recurring quering even if account does not exists and a few code cleanups.Workings are as follows
_addToSearch
._fetchAccounts
for 250ms to prevent unnecessary queries while the user still inputs data._fetchAccounts
will query all accounts still missing and process them. Any remaining which have failed (produced no return due to slow node non existing account) will be queried again, up tomax_fails
.Changelog