Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2756 - Account Selecotor Updates #2995

Merged
merged 15 commits into from
Aug 8, 2019
Merged

Conversation

startailcoon
Copy link
Contributor

@startailcoon startailcoon commented Jul 30, 2019

This PR closes #2756 (overrides previous PR)

This PR contains a significant larger change to the structure, most notable is the usage of fetchChainObjects, recurring quering even if account does not exists and a few code cleanups.

Workings are as follows

  • Component mounts and adds favorites and contacts to the searchResult list through _addToSearch.
  • User types an input and it gets added to teh searchResults list, which will hold _fetchAccounts for 250ms to prevent unnecessary queries while the user still inputs data.
  • _fetchAccounts will query all accounts still missing and process them. Any remaining which have failed (produced no return due to slow node non existing account) will be queried again, up to max_fails.
  • While query is running, a spinner will be visible at the end of the input.

Changelog

+ Query List
+ Query Cache w/ max query limitor
+ Require active select on Typeahead
+ Loading indicator when query running
+ Delayed querying on input
* Condensed code
* Removed unused code
* Fetch array of objects instead of single
* Results object creation changes
* Changes to error handling
* AccountImage default sizes  

+ Query List
+ Query Cache w/ max query limitor
+ Require active select on Typeahead
+ Loading indicator when query running
+ Delayed querying on input
* Condensed code
* Removed unused code
* Fetch array of objects instead of single
* Results object creation changes
* Changes to error handling
* AccountImage default sizes
* Error handling
@startailcoon
Copy link
Contributor Author

This PR does not update account fetching on any other component, only Account Selector.

startailcoon and others added 3 commits July 31, 2019 08:47
* Changed remaining ChainStore(getAccount) call
* Renamed functions and array to better namings
Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
* Changes to states
* Code simplifications
@startailcoon
Copy link
Contributor Author

@sschiessl-bcp removed some unnecessary state changes and added a re-fetch delay. I've tested the update frequency after this, and it seems to be much better.

startailcoon and others added 4 commits August 2, 2019 18:27
Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
- fix uncaught promise in trxhelper

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
@sschiessl-bcp
Copy link
Contributor

refactored the shit out of it and got lazy loading to work and fixed the amount selector styling
image

@sschiessl-bcp sschiessl-bcp merged commit 57486b1 into develop Aug 8, 2019
@sschiessl-bcp sschiessl-bcp deleted the 0_UpdatedAccountSelector branch September 25, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[7] Account Selector should not auto-match on type-ahead version
2 participants