Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1][OpenLedgerApp] Datetime picker Expiration - Missing tooltip #2356

Closed
TechsUsInc opened this issue Dec 18, 2018 · 8 comments · Fixed by #2638
Closed

[1][OpenLedgerApp] Datetime picker Expiration - Missing tooltip #2356

TechsUsInc opened this issue Dec 18, 2018 · 8 comments · Fixed by #2638
Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [4b] Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform [5b] Small Indicates size of task. Est. between one and two hours [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Milestone

Comments

@TechsUsInc
Copy link
Contributor

TechsUsInc commented Dec 18, 2018

Describe the bug

  1. The Datetime picker expiration is missing the tooltip once the default (1year) is clicked.
    181212rc-1_datetime_picker_1_capture

  2. It is not clear for the user that they can specify the expiry date and time outside of the specific pull
    down.

  3. Clicking on specific lastly contains specific twice.181212rc-1_datetime_picker_1_specific_capture

  4. Clicking the second specific closes the pull down list.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Exchange tab

  2. Click on the BTS tab for BitCNY:BTS pair

  3. Scroll down past the chart to buy/sell

  4. Click on default expiration of 1 year
    181212rc-1_datetime_picker_1_1yr_capture

  5. See error of missing timedate picker tooltip; see specific timedate picker tooltip
    181212rc-1_datetime_picker_1_capture

  6. Click on specific tooltip noting a second specific in the pull down list

  7. Click on the second specific in the pull down list noting it closes the pull down list

  8. Click the default timedate shown noting a calendar popup
    181212rc-1_datetime_picker_1_2_capture
    181212rc-1_datetime_picker_dec_capture

Expected behavior

  1. Timedate picker tooltip if default (1year) is clicked
    for a better user experience and self help
  2. Clicking specific or the current datetime picker (after clicking default 1 year) opens up the calendar (as in previous releases I think)
  3. Consider removing the second specific from the pull down list if possible to eliminate confusion. Or, replace the second word "specific" with "advanced"(same # letters) that opens up the calendar. The other options of 1 hour to 1 year are quick and easy.

Desktop (please complete the following information):

  • OS: Windows 8.1
  • Browser Opera
  • Version 56.0.3051.116
  • Release 181212rc-1

Additional context
Please see #2355

@startailcoon startailcoon added [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [5b] Small Indicates size of task. Est. between one and two hours [4b] Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Dec 18, 2018
@startailcoon startailcoon added this to the 190103 milestone Dec 18, 2018
@startailcoon startailcoon changed the title Datetime picker Expiration - Missing tooltip [1] Datetime picker Expiration - Missing tooltip Dec 18, 2018
@calvinfroedge calvinfroedge self-assigned this Dec 22, 2018
@startailcoon startailcoon modified the milestones: 190103, 190227 Feb 14, 2019
@startailcoon startailcoon modified the milestones: 190301, 190315 Mar 9, 2019
@clockworkgr clockworkgr modified the milestones: 190315, 190329 Mar 20, 2019
@clockworkgr clockworkgr modified the milestones: 190329, 190412 Apr 3, 2019
@startailcoon
Copy link
Contributor

@calvinfroedge please notify if you still intend to submit a PR for this task. Otherwise, free for claims.

@startailcoon startailcoon modified the milestones: 190412, 190426 Apr 14, 2019
@MikhailKavalenka
Copy link
Contributor

@startailcoon , I can take this one.

@startailcoon
Copy link
Contributor

Great, it's yours Mikhail

@OpenLedgerApp
Copy link

It took more time(6 hours) then planned, because:
-it was necessary to change logic for both forms(limit/scaled).
-Had some difficulties with implementation a datePicker into option of Select and re-change of "Specific" option.

@startailcoon startailcoon modified the milestones: 190426, 190510 Apr 28, 2019
@sschiessl-bcp
Copy link
Contributor

sschiessl-bcp commented Apr 30, 2019

What exactly were the changes (in words) that were done?
I suppose no one mentioned that styleguide comes with a new DatePicker?

@OpenLedgerApp
Copy link

OpenLedgerApp commented May 2, 2019

what was done:

  1. Added tooltips for options from 1 hour to 1 year
    https://user-images.githubusercontent.com/42674402/56679132-07ff2000-66cd-11e9-8df7-6984823c786e.png
  2. new logic for specific option:

No, we didn't use a new datePicker from "antd", but we can do it

@startailcoon
Copy link
Contributor

Please solve this with using Style Guide components available.

OpenLedgerApp pushed a commit to OpenLedgerApp/bitshares-ui that referenced this issue May 10, 2019
OpenLedgerApp pushed a commit to OpenLedgerApp/bitshares-ui that referenced this issue May 10, 2019
@OpenLedgerApp
Copy link

@startailcoon done

sschiessl-bcp pushed a commit that referenced this issue May 21, 2019
change expiration logic for limit/scaled forms
@clockworkgr clockworkgr changed the title [1] Datetime picker Expiration - Missing tooltip [1][OpenLedgerApp] Datetime picker Expiration - Missing tooltip May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [4b] Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform [5b] Small Indicates size of task. Est. between one and two hours [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants