-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX+UI:29][gibbsfromncis] Modal for Scaled Orders #1503
Comments
@abitmore Do we support it on server side? |
No, it would need to be done in the ui using multiple regular limit orders. That should be possible though, you can add multiple operations to one transaction. |
@svk31 got it. Nice. |
@wmbutler Can I just start to work on it or you want some UX changes there? (if yes please describe what exactly do you want to change and I'll ask some my designer to work on UX) This feature looks very useful for me and nice path to attract more traders. We already have useful charts (TradingView) and it's nice to work on orders part. |
This definitely needs UX proposed first and should fit into the Exchange redesign with ANT. |
@wmbutler I'll work on UX and UI both. |
UX for this task: @wmbutler @startailcoon |
@startailcoon final estimate is much more than I expected. It is 25 hours. I stuck on Fees / Markets fees calculations and fixes, orders creation but finally I did it. In result it looks really cool and awesome feature. One thing left is to add an ability to manage multiple orders to cancel them. Because using scaled orders users now can create unlimited count of orders and to cancel them users should click on circle and wait 3s until Exchange container update. I've created task for multiple orders management: #2317 |
Nice ground work @gibbsfromncis ! I see we can expand on the types you can make later. Now we have a basic frame to work from for making multiple orders. |
@startailcoon my apologies but when I said total is 25h I mean 25 for development. 2 hours for UX is bounty for designer who did it for me. |
I'm curious. What would be the max number of operations in one transaction, and what will happend when "Order Count" exceeds this number? Will the order itself be divided into several blocks? |
@fractalnode I suppose for the first version we will just limit amount of orders count but yes, it is possible to divide it by multiple transactions. |
Adjusted to 28 hours. 1 hour was spent to fix comments on PR #2316 |
Adjusted to 29. 1 hour was spent for investigation why Scaled Order Modal doesn't open in some cases. The reason was that if bindActionToState is missing some of "ChainType.required" parameter the component won't render without any error. Link to bug: #2498 |
As a trader I would like to be able to add scaled orders in the similar way to bitfinex
The text was updated successfully, but these errors were encountered: