Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX+UI:29][gibbsfromncis] Modal for Scaled Orders #1503

Closed
fractalnode opened this issue May 10, 2018 · 20 comments
Closed

[UX+UI:29][gibbsfromncis] Modal for Scaled Orders #1503

fractalnode opened this issue May 10, 2018 · 20 comments
Assignees
Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [2] Advanced Issue Issue is a technically advanced or complex task. Requires prior knowledge [3] Feature Classification indicating the addition of novel functionality to the design [4a] Low Priority Priority indicating minimal impact to system/user -OR- an inexpensive workaround exists [5d] Large Indicates size of task. Est. between four and ten hours [7] Finalized Administartion flag, notifies hours are finalized
Milestone

Comments

@fractalnode
Copy link

fractalnode commented May 10, 2018

As a trader I would like to be able to add scaled orders in the similar way to bitfinex

image

image

@wmbutler wmbutler added the [3] Enhancement Classification indicating a change to the functionality of the existing imlementation label May 11, 2018
@gibbsfromncis
Copy link
Contributor

@abitmore Do we support it on server side?

@svk31
Copy link
Contributor

svk31 commented Jun 16, 2018

No, it would need to be done in the ui using multiple regular limit orders. That should be possible though, you can add multiple operations to one transaction.

@gibbsfromncis
Copy link
Contributor

@svk31 got it. Nice.

@gibbsfromncis
Copy link
Contributor

gibbsfromncis commented Jun 18, 2018

@wmbutler Can I just start to work on it or you want some UX changes there? (if yes please describe what exactly do you want to change and I'll ask some my designer to work on UX)

This feature looks very useful for me and nice path to attract more traders. We already have useful charts (TradingView) and it's nice to work on orders part.

cc @startailcoon

@gibbsfromncis gibbsfromncis self-assigned this Jun 18, 2018
@gibbsfromncis gibbsfromncis changed the title Modal for Scaled Orders [gibbsfromncis] Modal for Scaled Orders Jun 18, 2018
@gibbsfromncis gibbsfromncis removed their assignment Jun 28, 2018
@fractalnode
Copy link
Author

fractalnode commented Jun 30, 2018

in fact, I meant a much simpler version.
something like that would be enough
image

@wmbutler
Copy link
Contributor

This definitely needs UX proposed first and should fit into the Exchange redesign with ANT.

@wmbutler wmbutler changed the title [gibbsfromncis] Modal for Scaled Orders [2][3][gibbsfromncis] Modal for Scaled Orders Jun 30, 2018
@wmbutler wmbutler added [3] Feature Classification indicating the addition of novel functionality to the design and removed [3] Enhancement Classification indicating a change to the functionality of the existing imlementation labels Jun 30, 2018
@wmbutler wmbutler added this to the 180715 milestone Jun 30, 2018
@gibbsfromncis
Copy link
Contributor

@wmbutler I'll work on UX and UI both.

@wmbutler wmbutler modified the milestones: 180720, 180803 Jul 23, 2018
@wmbutler wmbutler modified the milestones: 180801, 180815 Aug 6, 2018
@wmbutler wmbutler modified the milestones: 180815, 180905 Aug 26, 2018
@wmbutler wmbutler modified the milestones: 180905, 180919 Sep 13, 2018
@wmbutler wmbutler modified the milestones: 180919, 181003 Sep 25, 2018
@gibbsfromncis
Copy link
Contributor

gibbsfromncis commented Sep 26, 2018

UX for this task:

2018-09-17 02 26 16

@wmbutler @startailcoon
My estimate for UI implementation is 6h. Form implementation is not hard but code part of scaled orders a little bit complicated.
Please update the estimate or unassign myself

@gibbsfromncis gibbsfromncis changed the title [2][3][gibbsfromncis] Modal for Scaled Orders [2:UX:gibbsfromncis][3] Modal for Scaled Orders Sep 26, 2018
@gibbsfromncis gibbsfromncis changed the title [2:UX:gibbsfromncis][3] Modal for Scaled Orders [2:UX][gibbsfromncis][3] Modal for Scaled Orders Sep 26, 2018
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Dec 12, 2018
@gibbsfromncis
Copy link
Contributor

@startailcoon final estimate is much more than I expected. It is 25 hours.

I stuck on Fees / Markets fees calculations and fixes, orders creation but finally I did it. In result it looks really cool and awesome feature.

One thing left is to add an ability to manage multiple orders to cancel them. Because using scaled orders users now can create unlimited count of orders and to cancel them users should click on circle and wait 3s until Exchange container update.

I've created task for multiple orders management: #2317

@startailcoon
Copy link
Contributor

Nice ground work @gibbsfromncis ! I see we can expand on the types you can make later. Now we have a basic frame to work from for making multiple orders.

@startailcoon startailcoon changed the title [UX:2+UI:6][gibbsfromncis] Modal for Scaled Orders [UX:2+UI:25][gibbsfromncis] Modal for Scaled Orders Dec 15, 2018
@startailcoon startailcoon added the [7] Finalized Administartion flag, notifies hours are finalized label Dec 15, 2018
@startailcoon startailcoon changed the title [UX:2+UI:25][gibbsfromncis] Modal for Scaled Orders [UX+UI:25][gibbsfromncis] Modal for Scaled Orders Dec 15, 2018
@gibbsfromncis
Copy link
Contributor

@startailcoon my apologies but when I said total is 25h I mean 25 for development. 2 hours for UX is bounty for designer who did it for me.

@gibbsfromncis gibbsfromncis changed the title [UX+UI:25][gibbsfromncis] Modal for Scaled Orders [UX+UI:27][gibbsfromncis] Modal for Scaled Orders Jan 3, 2019
@gibbsfromncis gibbsfromncis modified the milestones: 181219, 190103 Jan 10, 2019
@startailcoon startailcoon modified the milestones: 190103, 190227 Feb 12, 2019
@fractalnode
Copy link
Author

I'm curious. What would be the max number of operations in one transaction, and what will happend when "Order Count" exceeds this number? Will the order itself be divided into several blocks?

@gibbsfromncis
Copy link
Contributor

@fractalnode I suppose for the first version we will just limit amount of orders count but yes, it is possible to divide it by multiple transactions.

gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Feb 21, 2019
@gibbsfromncis gibbsfromncis changed the title [UX+UI:27][gibbsfromncis] Modal for Scaled Orders [UX+UI:28][gibbsfromncis] Modal for Scaled Orders Feb 21, 2019
@gibbsfromncis
Copy link
Contributor

Adjusted to 28 hours. 1 hour was spent to fix comments on PR #2316

gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Feb 25, 2019
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Feb 25, 2019
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Feb 26, 2019
@gibbsfromncis
Copy link
Contributor

gibbsfromncis commented Feb 26, 2019

Adjusted to 29. 1 hour was spent for investigation why Scaled Order Modal doesn't open in some cases. The reason was that if bindActionToState is missing some of "ChainType.required" parameter the component won't render without any error.

Link to bug: #2498

sschiessl-bcp pushed a commit that referenced this issue Feb 26, 2019
@clockworkgr clockworkgr changed the title [UX+UI:28][gibbsfromncis] Modal for Scaled Orders [UX+UI:29][gibbsfromncis] Modal for Scaled Orders Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [2] Advanced Issue Issue is a technically advanced or complex task. Requires prior knowledge [3] Feature Classification indicating the addition of novel functionality to the design [4a] Low Priority Priority indicating minimal impact to system/user -OR- an inexpensive workaround exists [5d] Large Indicates size of task. Est. between four and ten hours [7] Finalized Administartion flag, notifies hours are finalized
Projects
None yet
Development

No branches or pull requests

5 participants