Fix test cases: if hf 343 and 890 occur at same maintenance interval #976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case
hf_935_test
was failing intestnet-hf-time
branch when bitasset data is updated before hard fork 890:bitshares-core/tests/tests/bitasset_tests.cpp
Line 1071 in e9defea
The reason is explained in the in-code comments:
bitshares-core/libraries/chain/db_maint.cpp
Lines 933 to 935 in e9defea
That said, if hf 343 and 890 occur at same maintenance interval, after median feed got updated by hf 890 code,
check_call_orders
will be called by hf 343 code, thus will finally produce a good result.This PR fixed the test case.