Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test cases: if hf 343 and 890 occur at same maintenance interval #976

Merged
merged 2 commits into from
May 25, 2018

Conversation

abitmore
Copy link
Member

The test case hf_935_test was failing in testnet-hf-time branch when bitasset data is updated before hard fork 890:

BOOST_CHECK( db.find<limit_order_object>( sell_id ) );

The reason is explained in the in-code comments:

// Note: due to bitshares-core issue #935, the check below (using median_changed) is incorrect.
// However, `skip_check_call_orders` will likely be true in both testnet and mainnet,
// so effectively the incorrect code won't make a difference.

That said, if hf 343 and 890 occur at same maintenance interval, after median feed got updated by hf 890 code, check_call_orders will be called by hf 343 code, thus will finally produce a good result.

This PR fixed the test case.

@abitmore
Copy link
Member Author

Pushed a new commit that fixes an unsigned integer underflow issue.

@abitmore abitmore merged commit e1e3ce8 into release May 25, 2018
@abitmore abitmore deleted the fix-935-test-case branch May 25, 2018 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants