Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement account_update_votes_operation #1367

Open
wants to merge 1 commit into
base: hardfork
Choose a base branch
from

Conversation

xeroc
Copy link
Member

@xeroc xeroc commented Oct 12, 2018

This PR introduces a new operation account_update_votes_operation that we feel is necessary in conjunction with BSIP40 and allows for setting a separate key for updating account votes. It has been manged in BSIP40

@xeroc
Copy link
Member Author

xeroc commented Oct 12, 2018

paging @Dimfred

@pmconrad
Copy link
Contributor

Who is "we"? IMO it is premature to determine what may be necessary when BSIP-40 has not even been implemented.

AFAICS BSIP-40 does not mention specific additional operations. This would require a separate BSIP.

@xeroc
Copy link
Member Author

xeroc commented Oct 12, 2018

Understood. Let us write a separate BSIP then.
The "we" is Blockchain Projects BV. We are currently growing our expertise in bitshares-core and would like to contriubute meaningfully .. This pull request as well as the #1368 come free of charge to the community.

@xeroc
Copy link
Member Author

xeroc commented Oct 12, 2018

I finally figured out why you were asking 'who is we'. I of course did not intend to mix up different roles and simply forgot to distinguish myself as being somewhat part in core development and my role as CTO of BCP. Sorry about that.

As you can see from the author of the commit, the work here is provided by BCP and seeks feedback by the core team to figure out if this is the right way to go. A BSIP will be provided.

@abitmore abitmore changed the base branch from develop to hardfork October 12, 2018 22:44
@abitmore abitmore changed the base branch from hardfork to develop October 12, 2018 22:47
@abitmore abitmore changed the base branch from develop to hardfork October 12, 2018 22:48
@xeroc
Copy link
Member Author

xeroc commented Oct 15, 2018

Please find a pull request for a corresponding BSIP here

@sschiessl-bcp
Copy link

The separate voting mechanism makes sense to also reduce communication overhead when voting.

Voting should be a regular activity (and we will hopefully be able to battle voter apathy more efficiently in the future), but currently requires the whole account options to be serialized even if just one vote is changed. This increases the serialized transaction size significantly, and is also quite intransparent to the user because no one can be expected to check the whole account option object when changing one vote.

The mentioning of BSIP40 is not a direct dependency, but a use case. BSIP40 will allow to create a "voting key", and a separate voting operation will facilitate the creation of if significantly (without it complicated restriction on the account option object must be created).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants