[bitnami/contour] Expose NodePort for the metrics port in the Envoy service #29818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deploying Contour behind an existing load balancer, such as an AWS ALB, health checks are often required for the target group. Currently, the Envoy health check endpoint is not exposed, making it unavailable for such checks. This change adds the option to expose the metrics port as a NodePort, enabling health checks to be performed. Signed-off-by: Mario de Frutos <mario@defrutos.org>
ethervoid
force-pushed
the
contour_include_metrics_as_nodeport
branch
from
bc7abbd
to
e38fb6a
Compare
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
carrodher
added
verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
When deploying Contour behind an existing load balancer, such as an AWS ALB, health checks are often required for the target group.
The Envoy health check endpoint is not exposed, making it unavailable for such checks. This change adds the option to expose the metrics port as a NodePort, enabling health checks to be performed.
Benefits
You're able to configure your Envoy service to expose the metrics as NodePort so you're able to perform external, from the Cluster, health checks to Envoy.
For example, if you're using a TargetGroupBinding you are not able to define those health checks pointing to the
/readyendpointPossible drawbacks
Nodes shouldn't be publicly accessible but if you define this NodePort those endpoints would be accessible from the outside.
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm