Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/contour] fixed wrong envoy-service-name arg value in contour when envoy service name is changed #29556

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

[bitnami/contour] fixed wrong envoy-service-name arg value in contour when envoy service name is changed #29556

wants to merge 15 commits into from

Conversation

3deep5me
Copy link
Contributor

@3deep5me 3deep5me commented Sep 20, 2024 •
edited
Loading

Description of the change

Fixes #29551 By adding a additional condition. Also fixed wrong value in envoy-service-name in contour deployment.
If multi-zone is enabled, the first service in the list will be the service name passed to contour.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added contour triage Triage is needed labels Sep 20, 2024
@3deep5me 3deep5me changed the title [bitnami/contour] fixed wrong envoy-service-name in contour when multiAz is enabled [bitnami/contour] fixed wrong envoy-service-name in contour when envoy service name is changed Sep 20, 2024
@3deep5me 3deep5me marked this pull request as ready for review September 20, 2024 15:28
@3deep5me 3deep5me changed the title [bitnami/contour] fixed wrong envoy-service-name in contour when envoy service name is changed [bitnami/contour] fixed wrong envoy-service-name arg value in contour when envoy service name is changed Sep 20, 2024
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Sep 21, 2024
@github-actions github-actions bot removed the triage Triage is needed label Sep 21, 2024
@github-actions github-actions bot removed the request for review from javsalgar September 21, 2024 11:05
jotamartos
jotamartos requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to create this PR. Could you please take a look at my comments?

bitnami/contour/templates/contour/deployment.yaml Show resolved Hide resolved
bitnami/contour/templates/contour/deployment.yaml Show resolved Hide resolved
@3deep5me
Copy link
Contributor Author

@jotamartos Thanks for the review.
I removed the double namespace.

jotamartos
jotamartos requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not noticing this in advance, could you please take a look at my comment? Let me know if you have any questions

bitnami/contour/templates/contour/deployment.yaml Show resolved Hide resolved
bitnami/contour/Chart.yaml Outdated Show resolved Hide resolved
3deep5me and others added 10 commits September 30, 2024 09:34
@3deep5me
fixed wrong envoy service name in contour deployment with multi-az en…
5142037 
…abled

Signed-off-by: 3deep5me <manuel.henke@caprox.eu>
@bitnami-bot @3deep5me
Update CHANGELOG.md
724e940 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: 3deep5me <manuel.henke@caprox.eu>
@bitnami-bot @3deep5me
Update CHANGELOG.md
532bdaa 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: 3deep5me <manuel.henke@caprox.eu>
@3deep5me
removed namespace out of the if/else
fa203fd 
Signed-off-by: 3deep5me <manuel.henke@caprox.eu>
@bitnami-bot @3deep5me
Update CHANGELOG.md
b05d382 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: 3deep5me <manuel.henke@caprox.eu>
@bitnami-bot @3deep5me
Update CHANGELOG.md
ea18332 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: 3deep5me <manuel.henke@caprox.eu>
@3deep5me @jotamartos
Bumped Version
28997a6 
Co-authored-by: Juan José Martos <jotamartos@gmail.com>
Signed-off-by: 3deep5me <73546509+3deep5me@users.noreply.github.com>
Signed-off-by: 3deep5me <manuel.henke@caprox.eu>
@3deep5me
Add Dep. note
42c3262 
Signed-off-by: 3deep5me <manuel.henke@caprox.eu>
@bitnami-bot @3deep5me
Update CHANGELOG.md
f7501b9 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: 3deep5me <manuel.henke@caprox.eu>
@3deep5me
added line to deployment
99ef8af 
Signed-off-by: 3deep5me <manuel.henke@caprox.eu>
3deep5me and others added 2 commits September 30, 2024 09:34
@3deep5me
fixed doc
c0ad62a 
Signed-off-by: 3deep5me <manuel.henke@caprox.eu>
@bitnami-bot @3deep5me
Update README.md with readme-generator-for-helm
136df8f 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: 3deep5me <manuel.henke@caprox.eu>
@bitnami-bot
Update CHANGELOG.md
607f518 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@3deep5me
Copy link
Contributor Author

3deep5me commented Oct 7, 2024

@jotamartos
I would be very grateful if you could take another look at it.

@bitnami-bot
Update CHANGELOG.md
9f54f34 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotamartos jotamartos Awaiting requested review from jotamartos

Requested changes must be addressed to merge this pull request.

Assignees

@jotamartos jotamartos

Labels
contour in-progress verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/contour] envoy service name change leads to empty status.loadBalancer field in Ingress-resource
5 participants
@3deep5me @jotamartos @javsalgar @carrodher @bitnami-bot