[bitnami/minio] Fix #29337: MinIO invalid ingress in network policy

[bartramakers]

Description of the change

This PR fixes two issues:

1. Removes duplicate extraIngress values in the NetworkPolicy
2. Fixed incorrect indentation for the extraIngress / extraFromClauses values

Benefits

No more errors when installing the chart because of incorrectly formatted yaml

Possible drawbacks

If somebody already took the incorrect indentation into account, and instead of making extraIngress values. they made extraFromClauses where they left out the from level, their output yaml will now be invalid.

Applicable issues

• fixes [bitnami/minio] MinIO chart generating invalid networkPolicy when using extraIngress parameter #29337

Checklist

• Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
• Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
• Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
• All commits signed off and in agreement of Developer Certificate of Origin (DCO)

[migruiz4]

Thank you for your contribution @bartramakers! Could you please take a look at my comment?

[migruiz4]

Using the template chart as reference, which is used to model all of the charts in our catalog, the code block we should keep is the one that has been removed:

charts/template/CHART_NAME/templates/networkpolicy.yaml

Lines 69 to 71 in 60473da

	{{- if .Values.networkPolicy.extraIngress }}
	{{- include "common.tplvalues.render" ( dict "value" .Values.networkPolicy.extraIngress "context" $ ) | nindent 4 }}
	{{- end }}

The value networkPolicy.extraFromClauses is a legacy value that was introduced before we defined the standard values for our networkPolicy templates.

I would suggest to modify the ingress block to look like this:

        {{- if .Values.networkPolicy.extraFromClauses }}
        {{- toYaml .Values.networkPolicy.extraFromClauses | nindent 8 }}
        {{- end }}
      {{- end }}
    {{- if .Values.networkPolicy.extraIngress }}
    {{- include "common.tplvalues.render" ( dict "value" .Values.networkPolicy.extraIngress "context" $ ) | nindent 4 }}
    {{- end }}

[github-actions]

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.