-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full state setpoints #382
Conversation
so now it flies with the demo script, but I think something still is off with the unpacking since it flies to 1.0 and still has a velocity. |
hmm if I use this full state setpoint for PID, it takes off, and it glides towards one direction, perhaps because the setpoint of roll pitch and yaw is 20 degrees in the beginning before showing the right setpoint at 0 degrees. It doesn't seem to be due to the compression. I haven't tested mellinger in flight yet but perhaps that doesn't happen? @whoenig is fullstatesetpoint suppose to work with PID as well or with mellinger alone? |
I think it should work with PID. Internally all it sets is position control in the setpoint struct (with feed-forward terms for velocity/acceleration, which the PID controller might ignore). |
that's what I thought... not sure where this would come from then especially since with PID, the attitude setpoint will get overwritten anyway, or else I would have thought that the compressing still goes wrong somewhere. So more investigation is necessary |
so I confirm, for mellinger, this does not work either. So more investigation is necessary! Next step:
|
Fixing the last parts |
So this adds the possibility to send full state set-point from the CFlib to the Crazyflie. This is in the light of that the decoders on the crazyflie crtp receiving should always be reflected in the cflib.
This includes a
It's in draft for now. I'm not sure if the compressing really works, and I get a packet is too large error so got to look at this as well. Btw, I based the compressing function on the cpp library by @whoenig