WIP: mempool stats chart #108

jonasschnelli · 2020-10-23T14:38:30Z

This PR adds a mempool statistics to the "debug" window.
The diagram is heavy inspired by Jochen Hoenicke's webversion (Thanks @jhoenicke for that).

macOS:

Ubuntu:

The approach is it to collect the fees also when the mempool chart or the node window is not open (collect it from the start of the application).
Clicking on the fee-range color square highlights the fee group over time.

To keep the scope minimal:

flexible timeframe is out of scope (can be added later)

See also bitcoin/bitcoin#8550 (an initial attempt, different concept).

TODO:

Make it non HiDPI compatible (linux/win/etc.).
Analyze memory consumption (should not be too bad)
Optimize performance
Try to make fee ranges dynamic

jonatack · 2020-10-23T14:55:19Z

Concept ACK -- nice!

RandyMcMillan · 2020-10-25T22:03:46Z

Should the background color of the Network Traffic display be changed to white as well? - to create a consistent UX within the different tabs? If so - should they share a common theme - so they can be toggled together?

RandyMcMillan · 2020-10-25T23:55:03Z

Concept ACK :)

It seems that the parent window should trigger a repaint/resize of the view simular to the peer table data model...

gui/src/qt/peertablemodel.cpp

Line 219 in d67883d

void PeerTableModel::refresh()

A similar implementation may be useful to actually hide the tab until the node is up and running and some initial values have been populated
Should flushing the mempool prior to shut down - as an option - be added to the tab as a check box? default no? This would allow the window to check cached data to speed up the initial paint.

gui/src/qt/bitcoingui.cpp

Line 840 in d67883d

void BitcoinGUI::showDebugWindowActivateConsole()

We can attempt to use similar settings to make a more consistent UX between the tabs by using the same dimensions for the data presentation view and the margin underneath...

PR #90

promag · 2020-10-26T00:55:44Z

Concept ACK.

Sjors · 2020-10-26T11:34:33Z

Very cool, concept ACK.

jonasschnelli · 2020-10-26T13:08:30Z

@RandyMcMillan
Thanks for the feedback.
I'd like to avoid visual alignment of both of the graphs in this PR. Off course this should happen but my takeaway from bitcoin/bitcoin#8550 is that scope creep must be avoided if we want to get this in master.

I recommend to do the visual alignment later on.

Sjors

The peers tab is dropped from the menu, try expanding std::vector<TabTypes> tabs() in rpcconsole.h

I managed to get a segfault by clicking on the chart (macOS), though only once. Also when clicking on an item in the legend.

You could split this into two PR's, one where the node collects all the histogram data and exposes it via RPC (with a functional test). And a GUI PR on top.

Sjors · 2020-10-30T11:06:55Z

src/qt/mempoolstats.cpp

+            ClickableRectItem *fee_rect = new ClickableRectItem();
+            fee_rect->setRect(4, c_y, c_w, c_h);
+
+            QColor brush_color = colors[(i < static_cast<int>(colors.size()) ? i : static_cast<int>(colors.size())-1)];


comparison of integers of different signs: 'int' and 'std::__1::vector<QColor, std::__1::allocator<QColor> >::size_type' (aka 'unsigned long') [-Werror,-Wsign-compare]

(a bunch of other warnings too)

hebasto · 2020-10-30T20:43:59Z

Concept ACK.

jarolrod

Concept ACK

One Note:
On macOS 11.1, Qt 5.15.2 - I can reliably cause a segmentation fault by clicking on any of the text on the left side. I can click on the corresponding box, but clicking on the text will cause a segmentation fault. Here is a pastebin link to the error report: https://pastebin.com/E7my5X8V

ghost · 2021-03-04T23:46:37Z

IMO the bar graph used by https://btc.bitaps.com is better than https://jochen-hoenicke.de/queue/#BTC%20(default%20mempool),24h

Reason: Its easy to look at it and use the information while broadcasting a bitcoin transaction

hebasto · 2021-03-19T14:36:04Z

IMO the bar graph used by https://btc.bitaps.com is better than https://jochen-hoenicke.de/queue/#BTC%20(default%20mempool),24h

Reason: Its easy to look at it and use the information while broadcasting a bitcoin transaction

I like it. It uses the widget area more effective.

rebroad · 2021-03-29T10:40:18Z

It would be ideal if the functionality of the previous graph and the new could be combined. e.g. allow different durations to be shown (from 3 hours, to 2 weeks), have one line for tx count, but show the fee rates within the memory usage graph. The scale (tx count and MB usage) could both be shown on the right, with the fee-rates shown on the left. Change the colours slightly so that the minfeerate and tx count are still clearly visible if plotted over the memusage/feerate. Oh, and ideally the window could be a separate window, rather than as a tab on the debug window.

At least, this would be perfection IMHO :)

rebroad · 2021-03-29T12:14:36Z

The functionality of clicking on a fee range and it displaying the number of transactions seems a bit off. In this example it's saying there are over 1,000,000 transactions in the 30-40 satoshi range, yet the vertical axis only goes up to 20,000 tx.

RandyMcMillan · 2021-05-06T08:18:01Z

#320 is a rebase of this PR.

hebasto · 2021-05-29T13:46:45Z

The "22.0" milestone seems unrealistic here. Removing it.

rebroad · 2021-07-03T12:49:50Z

Thinking it might be nice if the vertical axis scaled like it did on the old graph so that more detail can be seen...

Rspigler · 2021-07-13T16:24:02Z

@jonasschnelli Do you still have plans to work on this? Thanks!

laanwj · 2021-08-22T16:09:42Z

Concept ACK, this looks really neat. I think it's good for people running the GUI to have some introspection into what is happening on their node, and visualizations like this are useful for that.

DrahtBot · 2021-12-13T23:14:52Z

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

DrahtBot · 2022-03-21T12:12:00Z

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
Is it no longer relevant? ➡️ Please close.
Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

hebasto · 2022-04-13T15:14:22Z

Closing due to inactivity. Feel free to reopen.

Rspigler · 2022-04-26T18:32:44Z

Mark up for grabs?

hebasto · 2022-04-27T19:09:35Z

Mark up for grabs?

Done.

jonasschnelli added the Feature label Oct 23, 2020

jonasschnelli added this to the 0.22.0 milestone Oct 23, 2020

jonasschnelli force-pushed the 2020/03/mempool_graph branch from 7fcc1a1 to 2ea7ec8 Compare October 23, 2020 14:44

jonasschnelli force-pushed the 2020/03/mempool_graph branch 3 times, most recently from 96ee92a to 52267ab Compare October 24, 2020 09:41

WIP: mempool stats chart

bc78567

jonasschnelli force-pushed the 2020/03/mempool_graph branch from 52267ab to bc78567 Compare October 24, 2020 11:54

Sjors reviewed Oct 30, 2020

View reviewed changes

jarolrod reviewed Jan 21, 2021

View reviewed changes

RandyMcMillan mentioned this pull request May 6, 2021

WIP qt: mempool stats chart #320

Closed

hebasto removed this from the 22.0 milestone May 29, 2021

DrahtBot added the Needs rebase label Dec 13, 2021

hebasto closed this Apr 13, 2022

hebasto added the Up for grabs label Apr 27, 2022

bitcoin-core locked and limited conversation to collaborators Apr 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: mempool stats chart #108

WIP: mempool stats chart #108

jonasschnelli commented Oct 23, 2020 •

edited

Loading

jonatack commented Oct 23, 2020

RandyMcMillan commented Oct 25, 2020

RandyMcMillan commented Oct 25, 2020

promag commented Oct 26, 2020

Sjors commented Oct 26, 2020

jonasschnelli commented Oct 26, 2020

Sjors left a comment •

edited

Loading

Sjors Oct 30, 2020

hebasto commented Oct 30, 2020

jarolrod left a comment

ghost commented Mar 4, 2021

hebasto commented Mar 19, 2021

rebroad commented Mar 29, 2021 •

edited

Loading

rebroad commented Mar 29, 2021 •

edited

Loading

RandyMcMillan commented May 6, 2021

hebasto commented May 29, 2021

rebroad commented Jul 3, 2021

Rspigler commented Jul 13, 2021

laanwj commented Aug 22, 2021

DrahtBot commented Dec 13, 2021

DrahtBot commented Mar 21, 2022

hebasto commented Apr 13, 2022

Rspigler commented Apr 26, 2022

hebasto commented Apr 27, 2022

WIP: mempool stats chart #108

WIP: mempool stats chart #108

Conversation

jonasschnelli commented Oct 23, 2020 • edited Loading

jonatack commented Oct 23, 2020

RandyMcMillan commented Oct 25, 2020

RandyMcMillan commented Oct 25, 2020

promag commented Oct 26, 2020

Sjors commented Oct 26, 2020

jonasschnelli commented Oct 26, 2020

Sjors left a comment • edited Loading

Choose a reason for hiding this comment

Sjors Oct 30, 2020

Choose a reason for hiding this comment

hebasto commented Oct 30, 2020

jarolrod left a comment

Choose a reason for hiding this comment

ghost commented Mar 4, 2021

hebasto commented Mar 19, 2021

rebroad commented Mar 29, 2021 • edited Loading

rebroad commented Mar 29, 2021 • edited Loading

RandyMcMillan commented May 6, 2021

hebasto commented May 29, 2021

rebroad commented Jul 3, 2021

Rspigler commented Jul 13, 2021

laanwj commented Aug 22, 2021

DrahtBot commented Dec 13, 2021

DrahtBot commented Mar 21, 2022

hebasto commented Apr 13, 2022

Rspigler commented Apr 26, 2022

hebasto commented Apr 27, 2022

jonasschnelli commented Oct 23, 2020 •

edited

Loading

Sjors left a comment •

edited

Loading

rebroad commented Mar 29, 2021 •

edited

Loading

rebroad commented Mar 29, 2021 •

edited

Loading