Refactor converter generation code #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of code that focuses on lists of
curies.Recordobjects and instead works directly withcuries.Converterobjects.Along the way, this also identified issues with the data integrity on MIRIAM, N2T, and Prefix Commons with respect to the TAIR resources (
tair.geneandtair.protein) which all used non-specific, overlapping URLs. Therefore, these needed to get cleaned out before being import.Why do this? If we work directly with converters, we can make use of the CURIE prefix reconciliation tooling to more cleanly refactor the Bioregistry to Converter pipeline (which is causing issues when adding prefix casing variants in a related PR #969)