Add new prefix for OMIA variants #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matentzn
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
So cool OMIA and you are investing in this @marius-mather.. Really really great.
|
Thanks @marius-mather this looks great, once all the tests pass I will merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a prefix for genetic variants in OMIA, which are separate from the phenes currently accessible via the
omiaprefix.This is a new prefix that has not previously been registered with ID services, so I have removed most of the mappings to other services, but let me know if any of these mappings are required.
OMIA variants just have a straightforward numeric ID so the regex pattern for them is simple, and we have added a URL path for resolving them to the OMIA site, e.g. https://omia.org/variant/omia.variant:620/
Please let me know if anything further is required for this.