Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warnings.warn removed #80

Merged
merged 1 commit into from
Dec 17, 2020
Merged

warnings.warn removed #80

merged 1 commit into from
Dec 17, 2020

Conversation

WilliamIX
Copy link
Collaborator

mostly replaced with logging.info, except in cases users could fix the problem. In particular:

  • When species default to 0 as an initial condition, there is now no warning (but this is logged).
  • ODEint failed (but tried again) is now logged instead of a warning
  • A couple simulation initialization steps are logged, instead of warned.

warnings.warn removed
36af17e 
mostly replaced with logging.info, except in cases users could fix the problem.
@ayush9pandey
Copy link
Collaborator

All looks good to me.

@ayush9pandey
Copy link
Collaborator

Where's this log saved?

@ayush9pandey ayush9pandey merged commit cda7691 into master Dec 17, 2020
@ayush9pandey ayush9pandey deleted the fewer-warnings branch December 17, 2020 21:54
@WilliamIX WilliamIX restored the fewer-warnings branch January 6, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayush9pandey ayush9pandey ayush9pandey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilliamIX @ayush9pandey