This repository has been archived by the owner on Jun 2, 2018. It is now read-only.
Add type safe Entity Monitor #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| static public func newInContext(context: NSManagedObjectContext) -> Self { | ||
| return NSEntityDescription.insertNewObjectForEntityForName(entityName, inManagedObjectContext: context) as! Self | ||
| } |
There was a problem hiding this comment.
I've had success with this as an initializer:
extension CoreDataModelable {
static func entityInContext(context: NSManagedObjectContext) -> NSEntityDescription! {
guard let entity = NSEntityDescription.entityForName(entityName, inManagedObjectContext: context) else {
assertionFailure("Entity named \(entityName) doesn't exist. Fix the entity description or naming of \(Self.self).")
return nil
}
return entity
}
}
extension CoreDataModelable where Self: NSManagedObject {
init(managedObjectContext context: NSManagedObjectContext) {
self.init(entity: Self.entityInContext(context), insertIntoManagedObjectContext: context)
}
}
| */ | ||
| static public func findFirst(predicate: NSPredicate?, context: NSManagedObjectContext) -> Self? { | ||
| let fetchRequest = NSFetchRequest(entityName: entityName) | ||
| fetchRequest.predicate = predicate |
There was a problem hiding this comment.
Add fetchRequest.fetchLimit = 1 here to improve performance.
Rather than have the test case conform to EntityMonitorDelegate there are two distinct classes for each test type. This also shows an example of having EntityMonitors for two different Entity types.
This was an early attempt at triggering the MOC to observe object changes. Earlier addition of moc.processPendingChanges() is much more explicit and deterministic.
This ensures that if an entity is not in a supplied context it will assert with a useful failure rather than failing to force cast.
Including subentries is unnecessary since we're deleting objects. Also adding a note on how we could improve the performance using a batch delete request.
Limiting the batch and fetch size to a single result and returning the object already faulted
|
Updated based on all the comments. @lyricsboy and @zwaldowski want to take another pass? thanks. |
| import CoreData | ||
| import CoreDataStack | ||
|
|
||
| var insertExpectation: XCTestExpectation! |
There was a problem hiding this comment.
Would prefer to see these as instance variables and passed through initializers to the delegate classes.
There was a problem hiding this comment.
Yeah I considered that but that will not work for the way expectations are setup for the OnChange notification tests.
They need to be setup and waited on in a serial fashion so they cannot be setup in the delegate's initializer.
There was a problem hiding this comment.
I see what you mean now. We can proceed without this change.
lyricsboy
pushed a commit
that referenced
this pull request
Nov 20, 2015
Add type safe Entity Monitor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EntityMonitor observes a given NSManagedObjectContext for Updates, Deletes, and Inserts of a specific entity type. An optional filter predicate can also be added.
This can be used in place of an NSFetchedResultsController when you are not binding your data to an UITableViewController.