This repository has been archived by the owner on Jun 2, 2018. It is now read-only.
Ability to set NSPersistentStoreOptions #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Description is available
This makes it easier to add different configuration params to each platform
# Conflicts: # .travis.yml # Container Example/AppDelegate.swift # Container Example/BooksTableViewController.swift # CoreDataStack.xcodeproj/project.pbxproj # Gemfile.lock # Sources/CoreDataStack.swift # Sources/NSPersistentStoreCoordinator+SQLiteHelpers.swift # fastlane/Fastfile
houndci-bot
reviewed
Oct 28, 2016
| - parameter resetCallback: A callback with a `Success` or an `ErrorType` value with the error | ||
| */ | ||
| public func resetStore(callbackQueue: dispatch_queue_t? = nil, resetCallback: CoreDataStackStoreResetCallback) { | ||
| public func resetStore(callbackQueue: dispatch_queue_t? = nil, |
There was a problem hiding this comment.
Function Body Length Violation: Function body should span 40 lines or less excluding comments and whitespace: currently spans 53 lines (function_body_length)
|
CI is stuck but I ran locally and it looks good. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Ability to set NSPersistentStoreOptions for CoreDataStack
Addresses
#161