Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-982 Search results containing % symbol result in errored page. #2205

Merged
merged 2 commits into from
Apr 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Draft
- Search results containing % symbol result in errored page. [#2205](https://github.com/bigcommerce/cornerstone/issues/2205)
- Remove translations for adminBar component [#2196](https://github.com/bigcommerce/cornerstone/issues/2196)
- Remove adminBar. [#2191](https://github.com/bigcommerce/cornerstone/issues/2191)
- When price list price is set for currency, the cart does not respect product's price.[#2190](https://github.com/bigcommerce/cornerstone/issues/2190)
Expand Down
2 changes: 1 addition & 1 deletion assets/js/theme/global/quick-search.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export default function () {
return;
}

urlUtils.goToUrl(`${searchUrl}?search_query=${searchQuery}`);
urlUtils.goToUrl(`${searchUrl}?search_query=${encodeURIComponent(searchQuery)}`);
window.location.reload();
});
}