Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront): BCTHEME-383 Selecting certain option types pushes window view to the bottom of the page #1959

Merged
merged 2 commits into from
Jan 19, 2021
Merged

fix(storefront): BCTHEME-383 Selecting certain option types pushes window view to the bottom of the page #1959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8494746
fix(storefront): BCTHEME-383 Selecting certain option types pushes wi…
BC-tymurbiedukhin Jan 19, 2021
ed81bcf
merge master into BCTHEME-383
BC-tymurbiedukhin Jan 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Fixed selecting certain option types which pushes window view to the bottom of the page. [#1959](https://github.com/bigcommerce/cornerstone/pull/1959)
- Fixed case when default option is out of stock add to cart button does not populate for in stock options. [#1955](https://github.com/bigcommerce/cornerstone/pull/1955)
- Dots on carousel should have similar colours as other slider controls. [#1958](https://github.com/bigcommerce/cornerstone/pull/1958)
- PDP - Fixed Empty "Description" Hiding All Tabs When in Tab View. [#1947](https://github.com/bigcommerce/cornerstone/pull/1947)
Expand Down
7 changes: 5 additions & 2 deletions assets/scss/components/citadel/forms/_forms.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@

.form-checkbox,
.form-radio {
bottom: 0.5rem;
left: 0.5rem;

+ .form-label {

Expand All @@ -91,6 +89,11 @@
.form-option-wrapper {
position: relative;
display: inline-block;

& .form-radio, & .form-checkbox {
bottom: 0.5rem;
left: 0.5rem;
}
}

// Citadel form-actions
Expand Down