Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STRF-8769 Quick View - Image and price changes not reflected if an image is assigned to variant/sku #1884

Merged
merged 1 commit into from
Nov 18, 2020
Merged

STRF-8769 Quick View - Image and price changes not reflected if an image is assigned to variant/sku #1884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
- Cornerstone - Body text size above 14px is cut off on cart shipping dropdowns. [#1881](https://github.com/bigcommerce/cornerstone/pull/1881)
- Move Tax Field under Grand Total on Cart when Tax inclusive. [#1903](https://github.com/bigcommerce/cornerstone/pull/1903)
- Added styling config for the PayPal SPB on checkout page [#1866](https://github.com/bigcommerce/cornerstone/pull/1866)
- Moved zoomSize and productSize to the upper level, cause product.js is not availabe on the Quick View [#1884](https://github.com/bigcommerce/cornerstone/pull/1884)

## 4.12.1 (11-10-2020)
- Write a Review modal cause TypeError. [#1899](https://github.com/bigcommerce/cornerstone/pull/1899)
Expand Down Expand Up @@ -56,6 +57,7 @@
- Unified browsers list that we support. [#1836](https://github.com/bigcommerce/cornerstone/pull/1836)
- Bump stencil utils and update hooks to account for refactor to drop Jquery in stencil utils [#1821](https://github.com/bigcommerce/cornerstone/pull/1821)


## 4.11.0 (10-07-2020)
- Add Info and Add Coupon forms on Cart Page tabbable when hidden. [#1820](https://github.com/bigcommerce/cornerstone/pull/1820)
- Fixed outline styles for breadcrumbs on focus state. [#1824](https://github.com/bigcommerce/cornerstone/pull/1824)
Expand Down
3 changes: 3 additions & 0 deletions templates/layout/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@

{{{head.scripts}}}


{{~inject 'zoomSize' theme_settings.zoom_size}}
{{~inject 'productSize' theme_settings.product_size}}
BC-tymurbiedukhin marked this conversation as resolved.
Show resolved Hide resolved
{{~inject 'showAdminBar' theme_settings.show-admin-bar}}
{{~inject 'genericError' (lang 'common.generic_error')}}
{{~inject 'maintenanceModeSettings' settings.maintenance}}
Expand Down
4 changes: 1 addition & 3 deletions templates/pages/product.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@
similar_by_views:
limit: {{theme_settings.productpage_similar_by_views_count}}
---
{{inject "productId" product.id}}
{{inject "zoomSize" theme_settings.zoom_size}}
{{inject "productSize" theme_settings.product_size}}
{{inject 'productId' product.id}}

{{#partial "page"}}

Expand Down