Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront)bctheme-225:fix filter top outline on focus #1829

Merged
merged 2 commits into from
Oct 2, 2020
Merged

fix(storefront)bctheme-225:fix filter top outline on focus #1829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fbaf3a
fix(storefront)bctheme-225:fix filter top outline on focus
bc-alexsaiannyi Sep 9, 2020
44fdb2d
Merge branch 'master' into bctheme-225
BC-tymurbiedukhin Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Fixed missing top outline on chosen filter's focused. [#1829](https://github.com/bigcommerce/cornerstone/pull/1829)
- Added immediate keyboard focus on write-a-review modal. [#1835](https://github.com/bigcommerce/cornerstone/pull/1835)
- Fixed VoiceOver focus is not sync with keyboard focus on Faceted Search.[#1826](https://github.com/bigcommerce/cornerstone/pull/1826)
- Add collapsed/expanded state announcement by screen reader to add-info button within shipping estimator. [#1844](https://github.com/bigcommerce/cornerstone/pull/1844)
Expand Down
7 changes: 7 additions & 0 deletions assets/scss/components/foundation/inlineList/_inlineList.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,14 @@
// =============================================================================
// INLINE LIST (CSS)
// =============================================================================
// 1. It prevents from missing top outline on refine filters on focus;
//
// -----------------------------------------------------------------------------

ul.inlineList { // 1
overflow: visible;
@include clearfix;
}

.inlineList--labels {
margin-bottom: 0;
Expand Down