Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed cannot read property snapToNext of null in OnBoarding #641

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Fixed cannot read property snapToNext of null in OnBoarding #641

merged 2 commits into from
Feb 2, 2024

Conversation

paulsojan
Copy link
Contributor

@paulsojan paulsojan commented Jan 31, 2024 •
edited
Loading

Checklist

  • I have performed a self-review of my code and tested well before raising the PR.
  • I have made corresponding changes to the documentation and index.d.ts.
  • I've verified the change via .yalc in some neetoApp.

Demo or Screenshots

Breaking Change

@neetodeploy neetodeploy bot had a problem deploying to neeto-ui-rn-docs-pr-641 January 31, 2024 20:49 Failure
@paulsojan
Copy link
Contributor Author

Ref: meliorence/react-native-snap-carousel#552 (comment)

@paulsojan
Copy link
Contributor Author

@sangameshsomawar _a Please review

sangameshsomawar
sangameshsomawar approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@sangameshsomawar sangameshsomawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulsojan please add option chaining after current to be on safer side

@neetodeploy neetodeploy bot had a problem deploying to neeto-ui-rn-docs-pr-641 February 2, 2024 16:49 Failure
@paulsojan paulsojan merged commit 7c9719a into main Feb 2, 2024
@paulsojan paulsojan deleted the 640-fix-snap-to-next-null branch February 2, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangameshsomawar sangameshsomawar sangameshsomawar approved these changes

Assignees

@sangameshsomawar sangameshsomawar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Cannot read property 'snapToNext' of null in OnBoarding
2 participants
@paulsojan @sangameshsomawar