Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add human statement to emphasize that _desc is the last entity #1915

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link
Collaborator

@yarikoptic yarikoptic commented Aug 29, 2024

Partially addresses #1895

attn @arokem

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.23%. Comparing base (77ad779) to head (573a4c6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1915   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files          16       16           
  Lines        1410     1410           
=======================================
  Hits         1230     1230           
  Misses        180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies added this to the 1.10.1 milestone Aug 29, 2024
@arokem
Copy link
Collaborator

arokem commented Sep 3, 2024

Thanks! I don't think this quite covers the issue raised in #1895 though, because this points to a specific example, without stating explicitly that this is the convention for other cases as well. Does that make sense?

@yarikoptic
Copy link
Collaborator Author

Good observation @arokem ! our problem is that we do not really introduce _desc anywhere before. For now I just adjusted original description that it doesn't really close that issue, but I think for this could be a quick enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants