Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add noRF and n/a ASL volume types #1884

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 5, 2024

Closes #1762, but does not fully describe control-like "dummy" scans.

Changes proposed:

  • Allow noRF and n/a as allowed volume_type values in aslcontext files.
  • Allow noRF as a suffix for perfusion data.
  • Allow echo and part entities for _asl and _m0scan files.

@tsalo tsalo added the ASL label Aug 5, 2024
@tsalo tsalo requested a review from erdalkaraca as a code owner August 5, 2024 16:44
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we could get an example with noRF in bids-examples.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.23%. Comparing base (183499c) to head (05da908).
Report is 31 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1884   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files          16       16           
  Lines        1410     1410           
=======================================
  Hits         1230     1230           
  Misses        180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Member Author

tsalo commented Aug 5, 2024

Unfortunately, I don't have access to any data acquired with the HCP-Aging protocol. @aptinis would you happen to have any data from that protocol that could be shared openly as a BIDS example?

@aptinis
Copy link

aptinis commented Aug 6, 2024

Unfortunately, I don't have access to any data acquired with the HCP-Aging protocol. @aptinis would you happen to have any data from that protocol that could be shared openly as a BIDS example?

I'll check if I can get permission to share an example.

@tsalo
Copy link
Member Author

tsalo commented Aug 21, 2024

@aptinis have you had any luck with the example data?

@tsalo tsalo added this to the 1.10.0 milestone Aug 21, 2024
@aptinis
Copy link

aptinis commented Aug 21, 2024

@aptinis have you had any luck with the example data?

Yes, I was able to get permission to share an example. I will deface and BIDS format it. Where/how is the best way to share?

@tsalo
Copy link
Member Author

tsalo commented Aug 21, 2024

@Remi-Gau knows the most about the BIDS examples, so maybe he knows how best to share the dataset.

@effigies
Copy link
Collaborator

I would put the raw (ish) dataset on OSF or gin. If it's an actual dataset and not dummy data, then it would also be reasonable to post to OpenNeuro. Then you write a script to generate an example from the original; any changes to the original can then get propagated to the example with minimal effort.

@Remi-Gau
Copy link
Collaborator

What @effigies said.

@effigies
Copy link
Collaborator

@aptinis Just a note that an example is a blocking precondition to merging this. If we don't get it in this week, it will need to wait for a future version of the spec.

@aptinis
Copy link

aptinis commented Aug 28, 2024

@effigies Sorry for the delay. It is a real dataset with a single subject that has the 2D MB Multi-delay PCASL sequence of interest. It also has a 3D GRASE Multi-delay PCASL scan, a T1w and corresponding fmaps. I've started by creating a project for it on OSF, I am just working on fixing the BIDS validation before uploading. At the moment it passes with the old BIDS Validator v1.14.8 but fails with the latest schema version. Does the example need to pass the schema version of BIDS validation in order to be added to BIDS examples?

@effigies
Copy link
Collaborator

Please go ahead and create a PR and we can help figure out any issues.

@effigies

This comment was marked as resolved.

@effigies
Copy link
Collaborator

Sigh. I posted that comment on the wrong PR. I've pushed my suggested fix to this branch and will rerun the examples PR once this RTD build completes.

@Remi-Gau Remi-Gau merged commit 5f5f997 into bids-standard:master Sep 5, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aslcontext.tsv dummy volumes
4 participants