Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Use deidentification consistently in place of anonymization #1799

Conversation

DimitriPapadopoulos
Copy link
Collaborator

@DimitriPapadopoulos DimitriPapadopoulos commented Apr 22, 2024

In the vast majority of cases, strict anonymisation is impossible. Use the more generic term deidentification instead.

I suggest #1769 is merged first, then I can rebase and fix all occurrences.

Fixes #1782.

@effigies
Copy link
Collaborator

#1769 merged.

src/CHANGES.md Outdated
@@ -375,7 +375,7 @@
- \[MISC] Typo and style [#378](https://github.com/bids-standard/bids-specification/pull/378) ([TheChymera](https://github.com/TheChymera))
- \[FIX] divide readme into 3 parts [#374](https://github.com/bids-standard/bids-specification/pull/374) ([sappelhoff](https://github.com/sappelhoff))
- \[FIX] Refer to BIDS consistently, instead of "\<Modality>-BIDS" [#366](https://github.com/bids-standard/bids-specification/pull/366) ([sappelhoff](https://github.com/sappelhoff))
- \[FIX] Change recommended anonymization date from 1900 to 1925 [#363](https://github.com/bids-standard/bids-specification/pull/363) ([alexrockhill](https://github.com/alexrockhill))
- \[FIX] Change recommended deidentification date from 1900 to 1925 [#363](https://github.com/bids-standard/bids-specification/pull/363) ([alexrockhill](https://github.com/alexrockhill))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not modify CHANGES.md. If there's a typo in a PR, we can edit the PR and it will get updated next time the changelog generator is run. In this case, I think it's okay to leave, since it accurately describes the PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #363 is precisely about deidentififcation, not anonymisation - shifting dates so that "chances of identifying a person based on the date and time of their scan would be decreased". I have actually modified the paragraph modified by #363:

Examples include anonymization or defacing of the data, or

With that said, perhaps it is not worth chasing down this occurrence of anonymisation.

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.92%. Comparing base (01025da) to head (fcfcb37).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1799   +/-   ##
=======================================
  Coverage   87.92%   87.92%           
=======================================
  Files          16       16           
  Lines        1375     1375           
=======================================
  Hits         1209     1209           
  Misses        166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft April 22, 2024 15:36
In the vast majority of cases, strict anonymisation is impossible.
Use the more generic term deidentification instead.
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review April 22, 2024 15:44
@effigies effigies changed the title anonymisation → deidentification [ENH] Use deidentification consistently in place of anonymization Apr 22, 2024
@Remi-Gau Remi-Gau merged commit 0950f6d into bids-standard:master Apr 30, 2024
26 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the anonymisation_deidentification branch April 30, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

anonymization → deidentififcation (or pseudonymization)
3 participants