Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages #204

Merged
merged 6 commits into from
May 10, 2022
Merged

Improve error messages #204

merged 6 commits into from
May 10, 2022

Conversation

ThijsvdLaar
Copy link
Collaborator

@ThijsvdLaar ThijsvdLaar commented May 9, 2022

This PR fixes #27 , #70 , #146 , #194

@ThijsvdLaar ThijsvdLaar changed the title Error messages Improve error messages May 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #204 (c1a905a) into master (a3788e1) will increase coverage by 0.12%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   87.14%   87.27%   +0.12%     
==========================================
  Files          97       97              
  Lines        4614     4645      +31     
==========================================
+ Hits         4021     4054      +33     
+ Misses        593      591       -2     
Impacted Files Coverage Δ
src/distribution.jl 73.33% <0.00%> (-2.01%) ⬇️
src/engines/julia/update_rules/gaussian_moments.jl 95.55% <ø> (+3.55%) ⬆️
src/message_passing.jl 82.67% <60.00%> (-1.33%) ⬇️
src/algorithms/inference_algorithm.jl 90.47% <75.00%> (-5.45%) ⬇️
src/algorithms/expectation_propagation.jl 95.38% <100.00%> (+2.63%) ⬆️
src/algorithms/joint_marginals.jl 96.84% <100.00%> (+1.89%) ⬆️
src/algorithms/naive_variational_bayes.jl 96.82% <100.00%> (+2.79%) ⬆️
src/algorithms/posterior_factorization.jl 96.55% <100.00%> (+0.22%) ⬆️
src/algorithms/structured_variational_bayes.jl 96.38% <100.00%> (+2.13%) ⬆️
src/algorithms/sum_product.jl 96.47% <100.00%> (+0.96%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3788e1...c1a905a. Read the comment docs.

@ThijsvdLaar ThijsvdLaar marked this pull request as ready for review May 10, 2022 09:48
@ThijsvdLaar ThijsvdLaar merged commit 6965f7c into master May 10, 2022
@ThijsvdLaar ThijsvdLaar deleted the error_messages branch May 10, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cryptic error messages
2 participants