Several improvements / fixes for functions #320
Conversation
Dev v7.1.1 beta
…ray, instead of a string, for example:
{ "error": {
"message": [
"Invalid schema for function 'get_n_day_weather_forecast': In context=('properties', 'format'), array schema missing items"
],
"type": "invalid_request_error",
"param": null,
"code": null
}
}
This causes the JSON deserializer to choke.
There doesn't seem to be an official API documentation for error messages. However, since they appear to be only used for user feedback, I'd propose changing their type to be an unspecified `object`.
Merging into my dev branch: betalgo#312
|
Would be great to have something like this merged 👍 Question: Edit: |
|
When are you planning to merge this? |
If you're asking me, it's not my repo, I don't have any permissions here. This is waiting for @kayhantolga to review and merge. |
|
Hi Also, I left a comment, please check that. |
| @@ -13,7 +13,7 @@ public record Error | |||
| { | |||
| [JsonPropertyName("code")] public string? Code { get; set; } | |||
|
|
|||
| [JsonPropertyName("message")] public string? Message { get; set; } | |||
There was a problem hiding this comment.
Why do we need this? Do you have any sample responses that show why the change is necessary?
There was a problem hiding this comment.
Yes, please see the sample response in the description of commit 80bde47
It came back as an array of strings (rather than a string) which caused the JSON serializer to blow up
|
@rzubek do you think you can do the changes anytime soon? I want to include your changes into 7.2.0 |
|
Hi @kayhantolga, This PR is ready to go into dev, I don't think it's waiting for any more changes? Unless I missed something. Can you merge it to dev first, and then merge in your refactor from PR #334? The refactor is going to cause merge conflicts, and you're by far the best person to resolve them. |
New: function arguments can now be typed arrays, in addition to string, number, etc. Addresses issue #304 and part of issue #317. See AddArrayParameters().
Fix: error messages coming from the server caused exceptions to be thrown during deserialization; this is because the message field was coming back as an array but the deserializer expected a string.
Merged: PR #312. This code builds on PR 312 so it was incorporated.