Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed NaN validation, add no-gps-data class to map #618

Conversation

bonchan
Copy link
Contributor

@bonchan bonchan commented Dec 3, 2022

latitude and longitude validation was performed by checking the type of the variable.
this log has NaN values at latitude and longitude so the validation was not working.

@sonarcloud
Copy link

sonarcloud bot commented Dec 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bonchan
Copy link
Contributor Author

bonchan commented Dec 3, 2022

@haslinghuis do you know the origin of NaN values at latitude and longitude? it seems that G frames for this log have corrupted data.

@github-actions
Copy link

github-actions bot commented Dec 3, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
Betaflight-Blackbox-Explorer-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis
Copy link
Member

haslinghuis commented Dec 3, 2022

Here:
src/main/blackbox/blackbox.c:

@bonchan bonchan marked this pull request as ready for review December 4, 2022 21:20
@blckmn
Copy link
Member

blckmn commented Dec 4, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to the 3.7.0 milestone Dec 4, 2022
@haslinghuis haslinghuis merged commit 01a77ec into betaflight:master Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants