Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GPX exporter #614

Merged
merged 7 commits into from
Dec 2, 2022
Merged

Conversation

bonchan
Copy link
Contributor

@bonchan bonchan commented Nov 30, 2022

GPX files can be imported in google earth pro to show a 3d view of the flight to achieve something like this.

Instructions here

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@bonchan bonchan marked this pull request as ready for review November 30, 2022 18:21
@haslinghuis haslinghuis added this to the 3.7.0 milestone Nov 30, 2022
@blckmn
Copy link
Member

blckmn commented Nov 30, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@github-actions

This comment has been minimized.

js/main.js Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

haslinghuis
haslinghuis previously approved these changes Dec 1, 2022
@github-actions

This comment has been minimized.

haslinghuis
haslinghuis previously approved these changes Dec 1, 2022
js/gpx-exporter.js Outdated Show resolved Hide resolved
haslinghuis
haslinghuis previously approved these changes Dec 1, 2022
@github-actions

This comment has been minimized.

@haslinghuis
Copy link
Member

@bonchan please rebase

McGiverGim
McGiverGim previously approved these changes Dec 1, 2022
@McGiverGim
Copy link
Member

Good code! I think you need a rebase :)

@haslinghuis
Copy link
Member

Another reference for this awesome function: https://www.youtube.com/watch?v=uBXmUG6JZkc

@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
Betaflight-Blackbox-Explorer-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@bonchan
Copy link
Contributor Author

bonchan commented Dec 2, 2022

@bonchan please rebase

done!

@haslinghuis haslinghuis merged commit 127e76b into betaflight:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants