Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug friendly names depending on versioning #514

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

McGiverGim
Copy link
Member

This is a better implementation of #506 that maintains backward compatibility when needed.

@McGiverGim McGiverGim force-pushed the debug_names_versioning branch 3 times, most recently from 50b7b8a to 25dc3e6 Compare June 2, 2021 11:00
@McGiverGim
Copy link
Member Author

Sonar complained about tabs not being spaces... I've modified that too, the file is not too big, including lines not modified by me, so this can difficult a little the review. Sorry.

js/flightlog_fields_presenter.js Outdated Show resolved Hide resolved
js/flightlog_fields_presenter.js Outdated Show resolved Hide resolved
js/flightlog_fields_presenter.js Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ctzsnooze ctzsnooze self-requested a review June 6, 2021 23:34
Copy link
Member

@ctzsnooze ctzsnooze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really fantastic. Please merge!

@mikeller mikeller added this to the 3.6.0 milestone Jun 7, 2021
@mikeller mikeller merged commit eeff258 into betaflight:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants