Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move WebMWriter library to node_modules #463

Merged
merged 1 commit into from
Aug 2, 2020

Conversation

McGiverGim
Copy link
Member

@McGiverGim McGiverGim commented Jul 29, 2020

  • Moves the WebMWriter to be managed by yarn/npm.
  • Upgrades the library from version 0.1.1 to the latest 0.3.0. It seems compatible or at least my tests worked perfectly.

For a future, maybe is good to threat different when in Chrome or when in Node, the library has support for both.

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mikeller
Copy link
Member

I wouldn't worry too much about the future of the Chrome Web app:

  • Google has announced that they will finally be pulling the plug on Chrome Web Apps in Chrome by the end of the year;
  • even without this, we only have 33 users of the Chrome Web app version of the blackbox explorer.

We should probably just make the decision that the current versions of the configurator / blackboxe explorer will be the last ones to support Chrome Web Apps.

@mikeller mikeller added this to the 3.6.0 milestone Jul 29, 2020
@mikeller mikeller merged commit 90cb9ae into betaflight:master Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants