Change RC Rate and RC Command #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McGiverGim
force-pushed
the
change_rcrate_rccommand
branch
from
f4ea49d
to
0b6a336
Compare
mikeller
reviewed
May 12, 2018
js/graph_config.js
Outdated
| power: 0.8, | ||
| inputRange: 500 * (sysConfig.rcRate ? sysConfig.rcRate : 100) / 100, | ||
| power: 0.25, | ||
| inputRange: 500*1.20, // +20% to let compare in the same scale with the rccommands |
There was a problem hiding this comment.
Spaces around operator missing.
Change the meaning of this graphs to more useful values. The RC Command now shows the input of the sticks in us, and the RC Rate the deg/s of this input.
McGiverGim
force-pushed
the
change_rcrate_rccommand
branch
from
0b6a336
to
2ec67e8
Compare
|
Fixed. |
mikeller
approved these changes
May 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the meaning of this graphs to more useful values. The RC Command
now shows the input of the sticks in us, and the RC Rate the deg/s of
this input.
Fixes #138
@ctzsnooze can you test it to see if I now it is correct?
Some things to discuss:
gyro_scaleto calculate it is about 2000 deg/s), but with this value the graphs are too small by default.After that, my idea is to make another PR renaming some of the other graph fields to more "readable" values.