Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]Update yatai e2e tests to the latest python APIs #1483

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

yubozhao
Copy link
Contributor

@yubozhao yubozhao commented Mar 4, 2021

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Component(s) if applicable

  • BentoService (service definition, dependency management, API input/output adapters)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, dockerisation, logging, OpenAPI, instruments)
  • YataiService gRPC server (model registry, cloud deployment automation)
  • YataiService web server (nodejs HTTP server and web UI)
  • Internal (BentoML's own configuration, logging, utility, exception handling)
  • BentoML CLI

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #1483 (10a44b0) into master (772b765) will increase coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1483      +/-   ##
==========================================
+ Coverage   67.92%   68.65%   +0.72%     
==========================================
  Files         150      150              
  Lines       10045    10045              
==========================================
+ Hits         6823     6896      +73     
+ Misses       3222     3149      -73     
Impacted Files Coverage Δ
bentoml/frameworks/fastai.py 59.42% <0.00%> (-4.35%) ⬇️
bentoml/utils/__init__.py 87.03% <0.00%> (+1.85%) ⬆️
bentoml/service/inference_api.py 87.17% <0.00%> (+1.92%) ⬆️
bentoml/adapters/default_output.py 88.63% <0.00%> (+2.27%) ⬆️
bentoml/adapters/file_input.py 91.83% <0.00%> (+4.08%) ⬆️
bentoml/server/__init__.py 50.00% <0.00%> (+12.00%) ⬆️
bentoml/server/gunicorn_config.py 53.12% <0.00%> (+21.87%) ⬆️
bentoml/server/instruments.py 100.00% <0.00%> (+23.25%) ⬆️
bentoml/server/gunicorn_server.py 88.37% <0.00%> (+44.18%) ⬆️
bentoml/server/marshal_server.py 93.33% <0.00%> (+51.11%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 772b765...10a44b0. Read the comment docs.

@yubozhao yubozhao merged commit c607db2 into bentoml:master Mar 4, 2021
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
)

* update yatai e2e tests to the latest apis

* remove unnecessary retrieve
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant