Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Rewind fastai2 integration tests into project-based #1467

Merged
merged 10 commits into from
Mar 2, 2021

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Feb 23, 2021

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Component(s) if applicable

  • BentoService (service definition, dependency management, API input/output adapters)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, dockerisation, logging, OpenAPI, instruments)
  • YataiService gRPC server (model registry, cloud deployment automation)
  • YataiService web server (nodejs HTTP server and web UI)
  • Internal (BentoML's own configuration, logging, utility, exception handling)
  • BentoML CLI

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #1467 (0246e11) into master (bad87f1) will increase coverage by 0.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1467      +/-   ##
==========================================
+ Coverage   67.72%   68.65%   +0.92%     
==========================================
  Files         150      150              
  Lines       10017    10042      +25     
==========================================
+ Hits         6784     6894     +110     
+ Misses       3233     3148      -85     
Impacted Files Coverage Δ
bentoml/frameworks/fastai.py 59.42% <0.00%> (-4.35%) ⬇️
bentoml/saved_bundle/config.py 88.32% <0.00%> (-0.49%) ⬇️
bentoml/__init__.py 100.00% <0.00%> (ø)
bentoml/server/api_server.py 71.42% <0.00%> (ø)
bentoml/yatai/proto/repository_pb2.py 100.00% <0.00%> (ø)
bentoml/server/utils.py
bentoml/yatai/deployment/aws_ec2/templates.py 100.00% <0.00%> (ø)
bentoml/service/__init__.py 75.49% <0.00%> (+0.07%) ⬆️
bentoml/marshal/marshal.py 25.82% <0.00%> (+0.16%) ⬆️
bentoml/configuration/containers.py 86.48% <0.00%> (+0.18%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bad87f1...0246e11. Read the comment docs.

@bojiang bojiang changed the title Add project based fastai2 integration tests [CI] Rewrite fastai2 integration tests in project Feb 24, 2021
@bojiang bojiang added the pr/merge-hold Requires further discussions before a pull request can be merged label Feb 24, 2021
@bojiang bojiang changed the title [CI] Rewrite fastai2 integration tests in project [CI] Rewind fastai2 integration tests into project-based Feb 24, 2021
@bojiang bojiang removed the pr/merge-hold Requires further discussions before a pull request can be merged label Feb 24, 2021
@yubozhao
Copy link
Contributor

yubozhao commented Mar 2, 2021

LGTM

@parano parano merged commit b040add into bentoml:master Mar 2, 2021
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
* Add project based fastai2 integration tests

* install fastai

* renaming

* rm fastai_utils.py

* try to fix

* fix2

* fix3

* make linter happy

* make flake8 happy

* clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants