Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: menambahkan lasso Regession #284

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Conversation

kayabaakihiko13
Copy link
Member

Deskripsi (Description)

Checklist:

Umum:

  • Saya menambah algoritma terbaru.
  • Saya memperbaiki algoritma yang sudah ada.
  • Saya memperbaiki dokumentasi.
  • Saya menambah dokumentasi.

Contributor Requirements (Syarat Kontributor) dan Lain-Lain:

  • Saya sudah membaca (I have read) CONTRIBUTING dan sudah menyetujui semua syarat.
  • Saya telah menambahkan docstring yang memberikan penjelasan maksud dari kode yang saya buat.
  • Saya menggunakan bahasa Indonesia untuk memberikan penjelasan dari kode yang saya buat.

Unit Testing dan Linting:

  • pytest
  • flake8

Environment

Saya menggunakan (I'm using):

  • os = linux
  • python = python3 -V (unix)

linked issue #NOMOR_ISSUE

self.learning_path = learning_path
self.alpha = alpha

def fit(self, x: np.array, y: np.array) -> object:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def fit(self, x: np.array, y: np.array) -> object:
def fit(self, x: np.array, y: np.array) -> Any:

@@ -0,0 +1,100 @@
import numpy as np

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from typing import Any

@mergify mergify bot requested a review from a team June 30, 2023 20:46
Copy link
Member

@slowy07 slowy07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, terima kasih atas kontribusinya @kayabaakihiko13 !

@slowy07 slowy07 added the ready-to-merge ok to merge to branch main label Jul 3, 2023
@mergify mergify bot merged commit cc05009 into bellshade:main Jul 3, 2023
10 checks passed
@mergify
Copy link

mergify bot commented Jul 3, 2023

terima kasih atas kontribusinya @kayabaakihiko13 !

@mergify mergify bot requested a review from a team July 3, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants