feat: update algoritma ridge regession #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowy07
requested changes
Jun 21, 2023
Comment on lines
12
to
18
| def costfunction( | ||
| x_data: np.array, | ||
| y_data: np.array, | ||
| alpha: float, | ||
| weigth: np.array, | ||
| panjang_data: int, | ||
| ): |
There was a problem hiding this comment.
Suggested change
| def costfunction( | |
| x_data: np.array, | |
| y_data: np.array, | |
| alpha: float, | |
| weigth: np.array, | |
| panjang_data: int, | |
| ): | |
| def costfunction( | |
| x_data: np.ndarray, | |
| y_data: np.ndarray, | |
| alpha: float, | |
| weigth: np.ndarray, | |
| panjang_data: int, | |
| ) -> float: |
There was a problem hiding this comment.
untuk algoritmnya apa udah sesuai atau masih ada kesalahan kak @slowy07 ?
soalnya yang aku tahu ini dia sama kayak linear regession biasa kak
Comment on lines
26
to
32
| def step_gradient_descent( | ||
| data_x: np.array, | ||
| data_y: np.array, | ||
| alpha: float, | ||
| weight: np.array, | ||
| panjang_data: int, | ||
| ): |
There was a problem hiding this comment.
Suggested change
| def step_gradient_descent( | |
| data_x: np.array, | |
| data_y: np.array, | |
| alpha: float, | |
| weight: np.array, | |
| panjang_data: int, | |
| ): | |
| def step_gradient_descent( | |
| data_x: np.ndarray, | |
| data_y: np.ndarray, | |
| alpha: float, | |
| weight: np.ndarray, | |
| panjang_data: int, | |
| ) -> np.ndarray: |
| self.intercept = fit_intercept | ||
| self.iterasi = iterable | ||
| self.learning = learning_path | ||
| self.weight = None | ||
|
|
||
| def fit(self, x: np.array, y: np.array): |
There was a problem hiding this comment.
Suggested change
| def fit(self, x: np.array, y: np.array): | |
| def fit(self, x: np.ndarray, y: np.ndarray) -> np.ndarray: |
| error = costfunction(X, Y, self.learning, W, panjang_data) | ||
| print(f"pada iterasi {i + 1} - error : {error:.5f}") | ||
| self.weight = W | ||
| return self.weight | ||
|
|
||
| def transform(self, x: np.array): |
There was a problem hiding this comment.
Suggested change
| def transform(self, x: np.array): | |
| def transform(self, x: np.ndarray) -> np.ndarray: |
| self.predictions = X_predictor.dot(thetas) | ||
| if self.intercept: | ||
| X = np.c_[np.ones((X.shape[0], 1)), X] | ||
| self.predictions = X.dot(self.weight) | ||
| return self.predictions | ||
|
|
||
| def error_value(self, x: np.array, y: np.array): |
There was a problem hiding this comment.
Suggested change
| def error_value(self, x: np.array, y: np.array): | |
| def error_value(self, x: np.ndarray, y: np.ndarray) -> np.ndarray: |
There was a problem hiding this comment.
maksud dari line 59 ke 96,97,98 itu apa kak @slowy07 ?
for more information, see https://pre-commit.ci
slowy07
approved these changes
Jun 24, 2023
|
terima kasih atas kontribusinya @kayabaakihiko13 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deskripsi (Description)
Checklist:
Umum:
Contributor Requirements (Syarat Kontributor) dan Lain-Lain:
Unit Testing dan Linting:
Environment
Saya menggunakan (I'm using):
os=linuxpython=python3 -V (unix)linked issue #NOMOR_ISSUE