Skip to content
This repository has been archived by the owner on Mar 9, 2023. It is now read-only.

Modify README for customScanner sample usage. #157

Merged

Conversation

romanbalayan
Copy link
Contributor

@romanbalayan romanbalayan commented Oct 12, 2022

…irement to add sonar-scanner location to PATH env variable
@romanbalayan
Copy link
Contributor Author

Hi @dzienisz ,

Contributing as part of hacktoberfest 2022 (https://hacktoberfest.com/). If it's not too much of a bother, will it be okay to tag the PR with hacktoberfest-accepted label, just to it can be officially tagged as participating?

Thank you so much.

@dzienisz
Copy link
Contributor

Yes, thanks!

@gabssnake
Copy link
Collaborator

Hi @romanbalayan, I'd rather keep the example code shorter, only mentioning require('sonarqube-scanner').customScanner; since it is the only meaningful part.

Have you tried what you are suggesting, or are you basing this on inference?

@romanbalayan
Copy link
Contributor Author

Hi @gabssnake,

Sure, will take out the code block, and just maintain the specific change required when using the customScanner.

And yes, tried this out prior to creating the pull request.

@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@romanbalayan
Copy link
Contributor Author

Hi @gabssnake,

Anything I should be looking out for this?

Also @dzienisz, sorry to bother again, is it okay for the PR to be tagged with the hacktoberfest-accepted label?

Thanks!

@gabssnake
Copy link
Collaborator

LGTM

@gabssnake gabssnake merged commit 3e9c18d into bellingard:master Oct 25, 2022
@gabssnake gabssnake added this to the 2.9.0 milestone Oct 25, 2022
@gabssnake gabssnake mentioned this pull request Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants