Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve if directive formatting #404

Closed
belav opened this issue Aug 17, 2021 · 2 comments
Closed

Improve if directive formatting #404

belav opened this issue Aug 17, 2021 · 2 comments
Milestone

Comments

@belav
Copy link
Owner

belav commented Aug 17, 2021

Some things that don't work yet.

  1. nested directives
  2. if the final else needs a specific combination, that won't be in the set
  3. we don't actually look at not's correctly. Meaning #IF !ONE && TWO is parsed as ONE TWO, instead of just TWO
  4. related, for something like #IF ONE || TWO we only need one of the two symbols
  5. we may want to allow specifying symbolSets by file
  6. Unable to format when using if directives that contain the end of statements #121
@belav
Copy link
Owner Author

belav commented Aug 21, 2021

@belav belav added this to the Beta milestone Sep 18, 2021
@belav belav modified the milestones: Beta, 1.0.0 Feb 5, 2022
@belav belav modified the milestones: 1.0.0, 0.18.0 May 23, 2022
belav added a commit that referenced this issue May 23, 2022
belav added a commit that referenced this issue May 24, 2022
@belav belav modified the milestones: 0.18.0, 0.19.0 Jul 4, 2022
@belav belav modified the milestones: 0.19.0, 0.20.0 Aug 15, 2022
@belav
Copy link
Owner Author

belav commented Oct 3, 2022

@belav belav modified the milestones: 0.20.0, 1.0.0 Oct 3, 2022
@belav belav modified the milestones: 0.21.0, 0.22.0 Nov 28, 2022
@belav belav modified the milestones: 0.22.0, 0.23.0 Jan 4, 2023
@belav belav modified the milestones: 0.23.0, 0.24.0 Mar 6, 2023
@belav belav modified the milestones: 0.24.0, 0.25.0 Apr 26, 2023
belav added a commit that referenced this issue May 13, 2023
belav added a commit that referenced this issue May 13, 2023
@belav belav closed this as completed in 549ec0f Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant