Modify plugins to use dotnet tool list -g to find globally installed version #1267
Milestone
Comments
|
I am wondering if this is some kind of difference between the user the command runs as when executed in rider vs when you run the command yourself on the cli. But that doesn't really make sense if the command to install csharpier fails because it is already installed. The only thing I can think to try, is uninstall csharpier. And then let rider try to install it. Otherwise setting it up as a local tool would avoid the issue, because it will find the version from the dotnet-tools.json file. I can also look into modifying the extensions to make use of |
|
On mac using Rider, I've found that manually installing globally doesn't work. I had to install the plugin and then use the Rider provided option to install locally to the project. It then created the dotnet-tools.json file and worked. Using the Rider option to install globally also failed. |
|
I can confirm that uninstalling CSharpier globally, then installing it locally through the extension pop-up solves the issue. It also creates a .config folder in the project root. Installing it globally through the pop-up does not work for me either. I would really appreciate the possibility to use the already installed global tool, instead of a project-specific install. |
belav
changed the title
Is there anything in the logs when you try that indicates why it is failing? Ideally I'd get that working as well to avoid any confusion. |
|
Here is the log. I don't see anything that makes it clear why the global install process is failing. If there's any other place where I can look for debug logs outside of Rider logs, please let me know. As a side note, this log is after I reinstalled my OS and Rider, for unrelated reasons. |
belav
added a commit
that referenced
this issue
Aug 18, 2024
…l csharpier once + auto exclude some directories from warning. #1267
belav
added a commit
that referenced
this issue
Aug 18, 2024
#1323) This modifies the VSCode extension in the following ways - Instead of looking for dotnet-tools.json files in the current directory and parent directories the extension runs `dotnet tool list` and parses the outpud looking for the csharpier version. - Instead of running `dotnet csharpier --version` to look for the global version it repeats the above step with `dotnet tool list -g` - The "You need to install csharpier" window was popping up every time you opened a file if it couldn't find an install. The other extensions were limited to showing the warning a single time. VSCode now only shows it a single time. - Files under `/DecompilationMetadataAsSourceFileProvider/` will never have the warning show. This is where the c# dev kit decompiles code. #1267
belav
added a commit
that referenced
this issue
Aug 18, 2024
belav
added a commit
that referenced
this issue
Aug 18, 2024
|
I've updated all of the extensions so that they use |
pisolofin
pushed a commit
to pisolofin/csharpier-editorconfig
that referenced
this issue
Aug 22, 2024
belav#1323) This modifies the VSCode extension in the following ways - Instead of looking for dotnet-tools.json files in the current directory and parent directories the extension runs `dotnet tool list` and parses the outpud looking for the csharpier version. - Instead of running `dotnet csharpier --version` to look for the global version it repeats the above step with `dotnet tool list -g` - The "You need to install csharpier" window was popping up every time you opened a file if it couldn't find an install. The other extensions were limited to showing the warning a single time. VSCode now only shows it a single time. - Files under `/DecompilationMetadataAsSourceFileProvider/` will never have the warning show. This is where the c# dev kit decompiles code. belav#1267
pisolofin
pushed a commit
to pisolofin/csharpier-editorconfig
that referenced
this issue
Aug 22, 2024
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environments
Log Output
The following log appears after clicking "install csharpier globally" in the notification that says csharpier is not installed.
Steps to reproduce
dotnet tool install -g csharpierExpected behavior
Reformat with CSharpier should be clickable.
Actual behavior
Reformat with CSharpier is grayed out.
PATH has the dotnet tools:
CSharpier is two locations on disk:
The text was updated successfully, but these errors were encountered: