Handle not receiving a profile for a user in heroes

beeper · Dec 29, 2022 · 291630e · 291630e
1 parent d38aded
commit 291630e
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/synapse/handlers/sync.py b/synapse/handlers/sync.py
@@ -844,13 +844,18 @@ async def compute_summary(
                     summary["m.heroes"],
                 )
                 summary["com.beeper.m.heroes"] = [
-                    {"mxid": mxid, "display_name": profile.display_name}
+                    {
+                        "mxid": mxid,
+                        "display_name": profile.display_name
+                        if profile is not None
+                        else None,
+                    }
                     for mxid, profile in profiles.items()
                     if not mxid.startswith("@_")  # filter out bot users
                 ]
-            except Exception:
+            except Exception as e:
                 logger.warning(
-                    f"Error generating heroes for room {room_id} profiles {profiles}"
+                    f"Error generating heroes for room {room_id} profiles {profiles} error {e}"
                 )
                 raise