Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warning on self promotion #170

Merged
merged 2 commits into from
Jun 25, 2024
Merged

fix: warning on self promotion #170

merged 2 commits into from
Jun 25, 2024

Conversation

nstarman
Copy link
Contributor

Fixes #169

@nstarman
fix: warning on promotion
0e51833 
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman
Copy link
Contributor Author

I think I've fixed all other bugs, at least in quaxed. This is for unxt. Next we'll see what coordinax uncovers!

@nstarman nstarman marked this pull request as ready for review June 25, 2024 15:00
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9664837465

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 99.84%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plum/promotion.py 1 2 50.0%
Totals Coverage Status
Change from base Build 9552070800: -0.08%
Covered Lines: 1249
Relevant Lines: 1251
💛 - Coveralls

@nstarman
test: add test
95bc0d4 
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9665050245

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.92%
Totals Coverage Status
Change from base Build 9552070800: 0.0%
Covered Lines: 1250
Relevant Lines: 1251
💛 - Coveralls

@wesselb
Copy link
Member

wesselb commented Jun 25, 2024

@nstarman The warning seems to uncover a lot! 😅

Thanks for this PR. :) Merging right way. I’ll add one more test myself and then release a new version!

@wesselb wesselb merged commit 3292034 into beartype:master Jun 25, 2024
12 checks passed
@nstarman nstarman deleted the promotion branch June 25, 2024 16:45
nstarman
nstarman commented Jun 26, 2024
View reviewed changes
tests/test_promotion.py

# Test that explicit self-promotion works.
# This should also trigger the "escape hatch" in `add_promotion_rule`.
add_promotion_rule(Num, Num, Num)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cookie monster of promotion rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with parametric types and promotion
3 participants
@nstarman @coveralls @wesselb