Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: eom is correct, but expectation is wrong #146

Merged
merged 1 commit into from
Dec 4, 2015
Merged

Test failure: eom is correct, but expectation is wrong #146

merged 1 commit into from
Dec 4, 2015

Conversation

rbu
Copy link
Contributor

@rbu rbu commented Dec 4, 2015

This test fails in december, because the source time of calculation (s)
is in the next year (because it is generated after yr += 1).

Review on Reviewable

This test fails in december, because the source time of calculation (s)
is in the next year (because it is generated after yr += 1).
@codecov-io
Copy link

Current coverage is 77.09%

Merging #146 into master will not affect coverage as of f816af1

@@            master    #146   diff @@
======================================
  Files           14      14       
  Stmts         1554    1554       
  Branches       294     294       
  Methods          0       0       
======================================
  Hit           1198    1198       
  Partial         93      93       
  Missed         263     263       

Review entire Coverage Diff as of f816af1

Powered by Codecov. Updated on successful CI builds.

@bear
Copy link
Owner

bear commented Dec 4, 2015

nice! thanks for taking the time to fix this!

bear added a commit that referenced this pull request Dec 4, 2015
Test failure: eom is correct, but expectation is wrong
@bear bear merged commit 4d1f788 into bear:master Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants