Allows for conditionally hiding fields #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: * It is useful to be able to show or hide fields based on some condition on the data being passed to the serializer This change addresses the need by: * Passing `data` to the `hidden/1` function * Deprecating the `hidden/0` function with a warning, since it needs to be changed in all the serializers that use it. It keeps the existing behavior if a `hidden/0` function is found, so not to break any application
zamith
changed the title
doomspork
reviewed
Aug 29, 2018
lib/jsonapi/view.ex
Outdated
| @@ -107,7 +107,15 @@ defmodule JSONAPI.View do | |||
| end | |||
|
|
|||
| def attributes(data, conn) do | |||
| visible_fields = fields() -- hidden() | |||
| hidden = | |||
| if __MODULE__.__info__(:functions) |> Enum.member?({:hidden, 0}) do | |||
There was a problem hiding this comment.
I'd rather we avoid single pipes like this: https://github.com/christopheradams/elixir_style_guide#avoid-single-pipelines
There was a problem hiding this comment.
Sure, I tend to use only when the first argument is a bit long, but I don't have strong feelings about it
jeregrine
approved these changes
Aug 29, 2018
doomspork
approved these changes
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
on the data being passed to the serializer
This change addresses the need by:
datato thehidden/1functionhidden/0function with a warning, since it needs tobe changed in all the serializers that use it. It keeps the existing
behavior if a
hidden/0function is found, so not to break anyapplication