Omit non-Object meta #124
Merged
Omit non-Object meta #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refore not an object, as the specification requires. Cf. http://jsonapi.org/format/#document-meta Where specified, a meta member can be used to include non-standard meta-information. The value of each meta member MUST be an object (a “meta object”).
…map rather than not nil
|
I think this is a bugfix rather than an enhancement as |
doomspork
approved these changes
Aug 3, 2018
|
Thank you and welcome @kbaird 😁 I've corrected the label |
snewcomer
approved these changes
Aug 28, 2018
| @@ -117,8 +117,7 @@ defmodule JSONAPI.QueryParser do | |||
| requested_fields = | |||
| value | |||
| |> String.split(",") | |||
| |> Enum.map(&String.to_atom/1) | |||
| |> Enum.into(MapSet.new()) | |||
| |> Enum.into(MapSet.new(), &String.to_atom/1) | |||
jeregrine
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serializer was including
metaeven in cases where its value would not be an Object, which is not in compliance with the JSONAPI spec (http://jsonapi.org/format/#document-meta). This PR makes the serializer omit themetawhenis_map(meta)isfalse.I also DRYed up the tests, since my added ones re-used some of the existing default data.