SIMSBIOHUB-614: Fix file upload error handling.

[NickPhura]

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-614?

Description of Changes

Split the project/survey report/non-report attachment dialogs into 2 components.
Made 2 new attachment dialogs - one for single items, one for many items.
Added error handling to catch file upload errors.
Moved a few files around to group like-components.

Testing Notes

Changes to Project/Survey Report and Non-Report attachment upload

• Should work as before, and should handle any errors thrown during upload.

Changes to observation/telemetry/sample-site/animal csv import

• Should work as before, and should handle any errors thrown during upload.

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1366-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1366-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1366

[codecov]

Codecov Report

Attention: Patch coverage is 26.53061% with 72 lines in your changes missing coverage. Please review.

Project coverage is 48.49%. Comparing base (bc5663e) to head (2cd3f09).

Files with missing lines	Patch %	Lines
.../dialog/attachments/FileUploadSingleItemDialog.tsx	0.00%	24 Missing ⚠️
...urveys/telemetry/table/TelemetryTableContainer.tsx	0.00%	12 Missing ⚠️
.../src/features/projects/view/ProjectAttachments.tsx	31.25%	11 Missing ⚠️
...pp/src/features/surveys/view/SurveyAttachments.tsx	31.25%	11 Missing ⚠️
.../src/components/attachments/FileUploadWithMeta.tsx	14.28%	6 Missing ⚠️
...ents/dialog/attachments/ReportFileUploadDialog.tsx	61.53%	5 Missing ⚠️
...veys/animals/list/components/AnimalListToolbar.tsx	0.00%	1 Missing ⚠️
...le/import-obsevations/ImportObservationsButton.tsx	0.00%	1 Missing ⚠️
...ling-sites/components/ImportObservationsButton.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1366      +/-   ##
==========================================
- Coverage   48.56%   48.49%   -0.08%     
==========================================
  Files         771      772       +1     
  Lines       20706    20714       +8     
  Branches     3136     3127       -9     
==========================================
- Hits        10056    10045      -11     
- Misses      10498    10523      +25     
+ Partials      152      146       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mauberti-bc]

Tested locally and works well 👍

Minor future UI improvement: Closing the error dialog should also close the upload attachment dialog to avoid displaying "Complete" or "Success" on the upload dialog despite an error.

[NickPhura]

@mauberti-bc

Minor future UI improvement: Closing the error dialog should also close the upload attachment dialog to avoid displaying "Complete" or "Success" on the upload dialog despite an error.

The error popup was actually a copy/paste mistake. The file upload component handles individual file errors already, so I just had to remove the try/catch and let it bubble up:

Tweaked some other trivial stuff as well, and added some JSDoc. So should all be happy now.

[sonarcloud]

Quality Gate failed

Failed conditions
10.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[mauberti-bc]

👍