Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spi migrate users ups into test spi #1364

Merged
merged 35 commits into from
Sep 13, 2024
Merged

Spi migrate users ups into test spi #1364

merged 35 commits into from
Sep 13, 2024

Conversation

AMEIJER1
Copy link
Collaborator

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • {List all relevant code changes. Include any changes to the business workflow that might not be obvious to the reviewers of this PR.}

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

LouisThedroux and others added 25 commits August 28, 2024 12:07
…e script. Should work...maybe. Needs to be tested and debugged before merge
… lookup names once migation confirms final table values
…sons to determine if they have email addresses and give the collab role based on this. Joined on names. Not tested in current state
…name and lastname else default. Untested. May also be a bad idea, needs a review of logic
@AMEIJER1 AMEIJER1 added Do Not Merge PR should not be merged Not Ready For Review Addressing feedback and/or refactoring labels Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.10%. Comparing base (353675e) to head (06450af).
Report is 3 commits behind head on test-spi.

Additional details and impacted files
@@             Coverage Diff              @@
##           test-spi    #1364      +/-   ##
============================================
+ Coverage     47.88%   50.10%   +2.21%     
============================================
  Files           736      736              
  Lines         20015    20015              
  Branches       3146     3146              
============================================
+ Hits           9585    10028     +443     
+ Misses         9825     9819       -6     
+ Partials        605      168     -437     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMEIJER1 AMEIJER1 added Ready For Review PR is ready for review and removed Do Not Merge PR should not be merged Not Ready For Review Addressing feedback and/or refactoring labels Sep 12, 2024
Copy link

sonarcloud bot commented Sep 12, 2024

@AMEIJER1 AMEIJER1 merged commit cd09bc2 into test-spi Sep 13, 2024
10 checks passed
@AMEIJER1 AMEIJER1 deleted the spi-migrate-users_ups branch September 13, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants