Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert new method lookup values for SPI ETL #1358

Merged
merged 18 commits into from
Sep 18, 2024
Merged

Conversation

LouisThedroux
Copy link
Collaborator

@LouisThedroux LouisThedroux commented Sep 4, 2024

Links to Jira Tickets

  • N/A

Description of Changes

  • Adds new reference data used in the SPI ETL code

Testing Notes

  • Should see all the new lookup options (excluding undetermined) when creating a technique

@LouisThedroux LouisThedroux added the Ready For Review PR is ready for review label Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 48.56%. Comparing base (1c26829) to head (aad343a).

Files with missing lines Patch % Lines
...al-information/TechniqueGeneralInformationForm.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1358      +/-   ##
==========================================
- Coverage   48.57%   48.56%   -0.01%     
==========================================
  Files         771      771              
  Lines       20704    20706       +2     
  Branches     3135     3136       +1     
==========================================
  Hits        10056    10056              
- Misses      10496    10498       +2     
  Partials      152      152              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc mauberti-bc changed the title Method lookup update Insert new method lookup values for SPI ETL Sep 4, 2024
@MacQSL
Copy link
Collaborator

MacQSL commented Sep 4, 2024

Get this error when running make test

  • Run npm i in the API directory. Your local has outdated dependencies from recent PR's which were merged into dev. If you install the newly added ones this should go away.

@mauberti-bc mauberti-bc added Not Ready For Review Addressing feedback and/or refactoring and removed Ready For Review PR is ready for review labels Sep 4, 2024
@NickPhura
Copy link
Collaborator

@LouisThedroux Re error: Its a new package that was added just recently, so you probably just need to run make install (which just runs npm install in each sub-project)

@mauberti-bc mauberti-bc added Ready For Review PR is ready for review and removed Not Ready For Review Addressing feedback and/or refactoring labels Sep 11, 2024
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested the migration against existing techniques/methods associated to observations. Everything seems to work great.

Copy link

sonarcloud bot commented Sep 17, 2024

@NickPhura NickPhura merged commit bc5663e into dev Sep 18, 2024
21 of 22 checks passed
@NickPhura NickPhura deleted the method-lookup-update branch September 18, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants