Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerConfig class should be public API #136

Closed
thatsIch opened this issue Apr 11, 2018 · 2 comments
Closed

ServerConfig class should be public API #136

thatsIch opened this issue Apr 11, 2018 · 2 comments
Assignees
Milestone

Comments

@thatsIch
Copy link

thatsIch commented Apr 11, 2018

We require some post-validation after the mailer and email is constructed to check if all the required fields were set but calling

public class Mailer {
    ...
    public ServerConfig getServerConfig() {
    ...
}

returns a package private org.simplejavamail.mailer.ServerConfig which is also not declared as internal via package structure.

@bbottema bbottema self-assigned this Apr 11, 2018
@bbottema bbottema changed the title MailerBuilder generates Mailer with non public ServerConfig ServerConfig class should be public API Apr 11, 2018
@bbottema
Copy link
Owner

bbottema commented Apr 11, 2018

Yikes, that slipped the cracks. Thanks for the heads up. Released in Maven Central, v5.0.3

@thatsIch
Copy link
Author

Thanks for the quick fix!

Have a nice day :)

@bbottema bbottema added this to the 5.0.3 milestone Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants