Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSTEAMA-1382 Remove media player component, and add MediaLoader instead to OD Audio and Podcast pages #11998

Merged
merged 70 commits into from
Sep 30, 2024
Merged

WSTEAMA-1382 Remove media player component, and add MediaLoader instead to OD Audio and Podcast pages #11998

merged 70 commits into from
Sep 30, 2024

Conversation

Nabeel1276
Copy link
Contributor

@Nabeel1276 Nabeel1276 commented Sep 20, 2024 •
edited by holchris
Loading

Resolves JIRA 1382

Overall changes

Replaces AVPlayer with MediaLoader

Code changes

  • Uses MediaLoader for OnDemandAudio, removes legacy AVPlayer
  • Adds Bangala Radio, Indonesia Radio, Dari Radio and Persian Radio fixture data

Testing

  • Adds unit tests for page identifier overrides
  • Refactor unit test error handling to allow for more verbose error messages

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@Nabeel1276 Nabeel1276 self-assigned this Sep 20, 2024
@Nabeel1276 Nabeel1276 changed the title Wsteama 1382 remove media player component and add media loaders WSTEAMA-1382 remove media player component and add media loaders Sep 23, 2024
@holchris holchris changed the base branch from latest to WSTEAMA-1322-generate-smp-settings-object-for-on-demand-audio-&-add-tests September 23, 2024 10:36
@holchris holchris self-assigned this Sep 23, 2024
@holchris holchris changed the title WSTEAMA-1382 remove media player component and add media loaders WSTEAMA-1382 Remove media player component, and add MediaLoader instead to OD Audio and Podcast pages Sep 23, 2024
Base automatically changed from WSTEAMA-1322-generate-smp-settings-object-for-on-demand-audio-&-add-tests to latest September 23, 2024 14:48
Nabeel1276 and others added 21 commits September 23, 2024 16:16
@Nabeel1276
fixed typescript erros
ff274ed
@holchris
Merge branch 'WSTEAMA-1382-remove-media-player-component-and-add-medi…
f6956d3 
…aLoaders' of https://github.com/bbc/simorgh into WSTEAMA-1382-remove-media-player-component-and-add-mediaLoaders
@holchris
reorder imports
e606d4a
@holchris
Merge branch 'latest' into WSTEAMA-1382-remove-media-player-component…
ec6d521 
…-and-add-mediaLoaders
@holchris
refactor error logging for unit tests
242f9a6
@holchris
undo deletion
6990f90
@holchris
remove console log
d204935
@holchris
Merge branch 'WSTEAMA-1382-remove-media-player-component-and-add-medi…
b45fd50 
…aLoaders' of https://github.com/bbc/simorgh into WSTEAMA-1382-remove-media-player-component-and-add-mediaLoaders
@holchris
adds persian podcast fixture data
44a804a
@holchris
tests for persian podcast overrides
61ece32
@Nabeel1276
finished creating test for persian podcast
a904c13
@holchris
Merge branch 'WSTEAMA-1382-remove-media-player-component-and-add-medi…
032c11e 
…aLoaders' of https://github.com/bbc/simorgh into WSTEAMA-1382-remove-media-player-component-and-add-mediaLoaders
@Nabeel1276
Merge branch 'latest' into WSTEAMA-1382-remove-media-player-component…
104bc99 
…-and-add-mediaLoaders
@Nabeel1276
attempted to add fixture data and add tests for bengali brand
71658e6
@Nabeel1276
fixed errors in test and added bengali data for mock response
281e94b
@Nabeel1276
Merge branch 'latest' into WSTEAMA-1382-remove-media-player-component…
64e8a63 
…-and-add-mediaLoaders
@Nabeel1276
updated indonesian radio fixture data
d6d8121
@Nabeel1276
added unit tests for indonesian service
7faf8be
@Nabeel1276
added fixture data for dari radio
d8798c5
@holchris
Merge branch 'WSTEAMA-1382-remove-media-player-component-and-add-medi…
3dd320a 
…aLoaders' of https://github.com/bbc/simorgh into WSTEAMA-1382-remove-media-player-component-and-add-mediaLoaders
@Nabeel1276
updated tests for persian dari radio
b4923ea
@alex-magana alex-magana force-pushed the WSTEAMA-1382-remove-media-player-component-and-add-mediaLoaders branch from f731f68 to 302a6ba Compare September 27, 2024 14:15
@alex-magana alex-magana marked this pull request as ready for review September 28, 2024 16:27
@holchris
Merge branch 'WSTEAMA-1382-remove-media-player-component-and-add-medi…
3418547 
…aLoaders' of https://github.com/bbc/simorgh into WSTEAMA-1382-remove-media-player-component-and-add-mediaLoaders
@alex-magana @karinathomasbbc
Update src/app/pages/OnDemandAudioPage/index.test.tsx
e3da7c5 
Co-authored-by: Karina Thomas <58214768+karinathomasbbc@users.noreply.github.com>
eagerterrier
eagerterrier approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@eagerterrier eagerterrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T-Shirt-Image-2_1-1

@eagerterrier eagerterrier merged commit 85f5314 into latest Sep 30, 2024
11 checks passed
@eagerterrier eagerterrier deleted the WSTEAMA-1382-remove-media-player-component-and-add-mediaLoaders branch September 30, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amoore108 amoore108 amoore108 left review comments

@alex-magana alex-magana alex-magana left review comments

@karinathomasbbc karinathomasbbc karinathomasbbc approved these changes

@eagerterrier eagerterrier eagerterrier approved these changes

Assignees

@holchris holchris

@Nabeel1276 Nabeel1276

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Nabeel1276 @eagerterrier @amoore108 @alex-magana @karinathomasbbc @holchris