Render the script switch button on the header container on storybook #11984
+182
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karinathomasbbc
changed the title
emilysaffron
approved these changes
Sep 18, 2024
Guess no harm in leaving it for now. It would be good to go and clean up the stories & remove dupes, but not today 😅 |
karinathomasbbc
commented
Oct 1, 2024
…torybook-script-link
…torybook-script-link
…s only) from the sidebar
…torybook-script-link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA N/A
Overall changes
Ensures the script link component is visible on the header for variant services
Code changes
Allow script link to appear on the Header container for all variant services
Testing
Serbian
https://storybook-script-link--5d28eb3fe163f6002046d6fa.chromatic.com/?path=/story/containers-header--header&globals=service.service:serbian;service.variant:cyr
https://storybook-script-link--5d28eb3fe163f6002046d6fa.chromatic.com/?path=/story/containers-header--header&globals=service.service:serbian;service.variant:lat
UKChina
https://storybook-script-link--5d28eb3fe163f6002046d6fa.chromatic.com/?path=/story/containers-header--header&globals=service.service:ukchina;service.variant:simp
https://storybook-script-link--5d28eb3fe163f6002046d6fa.chromatic.com/?path=/story/containers-header--header&globals=service.service:ukchina;service.variant:trad
Zhongwen
https://storybook-script-link--5d28eb3fe163f6002046d6fa.chromatic.com/?path=/story/containers-header--header&globals=service.service:zhongwen;service.variant:simp
https://storybook-script-link--5d28eb3fe163f6002046d6fa.chromatic.com/?path=/story/containers-header--header&globals=service.service:zhongwen;service.variant:trad
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines