Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvements for blending functions such that bleeding with background clearColor is avoided #134

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

improvements for blending functions such that bleeding with background clearColor is avoided #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b7eef5a
improvements for blending functions such that bleeding with backgroun…
munwaikong Jan 14, 2019
8b3584a
Merge branch 'develop' into blending2
PTaylour Jan 29, 2019
08da178
Merge branch 'develop' into blending2
PTaylour Feb 4, 2019
5f077f9
Merge branch 'develop' into blending2
PTaylour Jun 6, 2019
721b1a4
Merge branch 'develop' into blending2
PTaylour Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/DestinationNode/destinationnode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,14 @@ class DestinationNode extends ProcessingNode {
let gl = this._gl;

gl.bindFramebuffer(gl.FRAMEBUFFER, null);
gl.blendFunc(gl.SRC_ALPHA, gl.ONE_MINUS_SRC_ALPHA);
gl.enable(gl.BLEND);
gl.clearColor(0, 0, 0, 0.0); // green;
gl.clear(gl.COLOR_BUFFER_BIT);

// Set the initial blend function to 'proiritize' the SRC so that the background
// clearColor doesn't bleed / blend into output
gl.enable(gl.BLEND);
gl.blendFunc(gl.ONE, gl.ZERO);

this.inputs.forEach(node => {
super._render();
//map the input textures input the node
Expand All @@ -46,6 +49,10 @@ class DestinationNode extends ProcessingNode {
}

gl.drawArrays(gl.TRIANGLES, 0, 6);

// Update the blend function to allow for 'default' blend of transparency
// of the next inputs of the node
gl.blendFunc(gl.SRC_ALPHA, gl.ONE_MINUS_SRC_ALPHA);
});
}
}
Expand Down
19 changes: 18 additions & 1 deletion src/ProcessingNodes/compositingnode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@ class CompositingNode extends ProcessingNode {
);
gl.clearColor(0, 0, 0, 0); // green;
gl.clear(gl.COLOR_BUFFER_BIT);
gl.blendFuncSeparate(gl.SRC_ALPHA, gl.ONE_MINUS_SRC_ALPHA, gl.ONE, gl.ONE_MINUS_SRC_ALPHA);

// Set the initial blend function to 'proiritize' the SRC so that the background
// clearColor doesn't bleed / blend into output
gl.enable(gl.BLEND);
gl.blendFunc(gl.ONE, gl.ZERO);

this.inputs.forEach(node => {
if (node === undefined) return;
Expand All @@ -54,6 +58,19 @@ class CompositingNode extends ProcessingNode {
}

gl.drawArrays(gl.TRIANGLES, 0, 6);

// Update the blend function to allow for 'default' blend of transparency
// of the next inputs of the node
gl.blendFuncSeparate(
gl.SRC_ALPHA,
gl.ONE_MINUS_SRC_ALPHA,
gl.ONE,
gl.ONE_MINUS_SRC_ALPHA
);
// We blend RGB and Alpha separately because as you stack layers in a CompositionNode, we don’t want to interpolate alpha
// (i.e. we don’t want a mid-point or a weighted average of the alpha channels)
// Transparent things in real life don’t blend. The colors blend, but the opacity gets monotonically more opaque as things pile up
// (i.e. stack two transparent gels and the result is more opaque than either one individually)
});

gl.bindFramebuffer(gl.FRAMEBUFFER, null);
Expand Down
4 changes: 4 additions & 0 deletions src/ProcessingNodes/effectnode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ class EffectNode extends ProcessingNode {
);
gl.clearColor(0, 0, 0, 0); // green;
gl.clear(gl.COLOR_BUFFER_BIT);

// Set the initial blend function to 'proiritize' the SRC so that the background
// clearColor doesn't bleed / blend into output
gl.enable(gl.BLEND);
gl.blendFunc(gl.ONE, gl.ZERO);

super._render();
Expand Down