Be resilient with Bazel-built transitive dependencies duplicates #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
irengrig
commented
Sep 17, 2019
irengrig
commented
- it is possible that some duplicate libraries, built with Bazel, will be passed as inputs to cmake_external or configure_make. rules_foreign_cc should filter duplicates out rather then fail.
- add a test (which just builds the target) //cmake_synthetic:lib_with_duplicate_transitive_bazel_deps
- it is possible that some duplicate libraries, built with Bazel, will be passed as inputs to cmake_external or configure_make. rules_foreign_cc should filter duplicates out rather then fail. - add a test (which just builds the target) //cmake_synthetic:lib_with_duplicate_transitive_bazel_deps
jin
approved these changes
Sep 17, 2019
.bazelci/config.yaml
Outdated
| @@ -5,6 +5,7 @@ tasks: | |||
| working_directory: examples | |||
| build_targets: | |||
| - "//cmake_android:app" | |||
| - "//cmake_synthetic:lib_with_duplicate_transitive_bazel_deps" | |||
There was a problem hiding this comment.
Use https://github.com/bazelbuild/bazel-skylib/blob/master/rules/build_test.bzl and make it a test target?
| @@ -443,6 +443,7 @@ def _copy_deps_and_tools(files): | |||
| return lines | |||
|
|
|||
| def _symlink_contents_to_dir(dir_name, files_list): | |||
| files_list = collections.uniq(files_list) | |||
There was a problem hiding this comment.
Add a comment here?
"It is possible that some duplicate libraries will be passed as inputs to cmake_external or configure_make. Filter duplicates out here."
|
Thank you so much for so quick review! |
alyssawilk
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Sep 23, 2019
This updates rules_foreign_cc to include bazel-contrib/rules_foreign_cc#318 The patch may fix some OSS-Fuzz build failures related to transitive dependencies in curl coming from #8154 Risk level: Low Signed-off-by: Asra Ali <asraa@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Sep 24, 2019
This updates rules_foreign_cc to include bazel-contrib/rules_foreign_cc#318 The patch may fix some OSS-Fuzz build failures related to transitive dependencies in curl coming from envoyproxy#8154 Risk level: Low Signed-off-by: Asra Ali <asraa@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
This updates rules_foreign_cc to include bazel-contrib/rules_foreign_cc#318 The patch may fix some OSS-Fuzz build failures related to transitive dependencies in curl coming from envoyproxy#8154 Risk level: Low Signed-off-by: Asra Ali <asraa@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
This updates rules_foreign_cc to include bazel-contrib/rules_foreign_cc#318 The patch may fix some OSS-Fuzz build failures related to transitive dependencies in curl coming from envoyproxy#8154 Risk level: Low Signed-off-by: Asra Ali <asraa@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.